From 029e8a10afdd86b5c4c2f0e91f933bdd07fe5d2c Mon Sep 17 00:00:00 2001 From: Soby Chacko Date: Wed, 21 May 2025 19:34:15 -0400 Subject: [PATCH] test: fix useAutoConfiguredJdbcChatMemoryRepository test after connection leak fix Add schema initialization property after commit 560540f properly closed connections Signed-off-by: Soby Chacko --- ...positoryPostgresqlAutoConfigurationIT.java | 31 ++++++++++--------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/auto-configurations/models/chat/memory/repository/spring-ai-autoconfigure-model-chat-memory-repository-jdbc/src/test/java/org/springframework/ai/model/chat/memory/repository/jdbc/autoconfigure/JdbcChatMemoryRepositoryPostgresqlAutoConfigurationIT.java b/auto-configurations/models/chat/memory/repository/spring-ai-autoconfigure-model-chat-memory-repository-jdbc/src/test/java/org/springframework/ai/model/chat/memory/repository/jdbc/autoconfigure/JdbcChatMemoryRepositoryPostgresqlAutoConfigurationIT.java index db75aa22d..c6bde91ff 100644 --- a/auto-configurations/models/chat/memory/repository/spring-ai-autoconfigure-model-chat-memory-repository-jdbc/src/test/java/org/springframework/ai/model/chat/memory/repository/jdbc/autoconfigure/JdbcChatMemoryRepositoryPostgresqlAutoConfigurationIT.java +++ b/auto-configurations/models/chat/memory/repository/spring-ai-autoconfigure-model-chat-memory-repository-jdbc/src/test/java/org/springframework/ai/model/chat/memory/repository/jdbc/autoconfigure/JdbcChatMemoryRepositoryPostgresqlAutoConfigurationIT.java @@ -73,28 +73,29 @@ class JdbcChatMemoryRepositoryPostgresqlAutoConfigurationIT { @Test void useAutoConfiguredJdbcChatMemoryRepository() { - this.contextRunner.run(context -> { - var chatMemoryRepository = context.getBean(JdbcChatMemoryRepository.class); - var conversationId = UUID.randomUUID().toString(); - var userMessage = new UserMessage("Message from the user"); + this.contextRunner.withPropertyValues("spring.ai.chat.memory.repository.jdbc.initialize-schema=always") + .run(context -> { + var chatMemoryRepository = context.getBean(JdbcChatMemoryRepository.class); + var conversationId = UUID.randomUUID().toString(); + var userMessage = new UserMessage("Message from the user"); - chatMemoryRepository.saveAll(conversationId, List.of(userMessage)); + chatMemoryRepository.saveAll(conversationId, List.of(userMessage)); - assertThat(chatMemoryRepository.findByConversationId(conversationId)).hasSize(1); - assertThat(chatMemoryRepository.findByConversationId(conversationId)).isEqualTo(List.of(userMessage)); + assertThat(chatMemoryRepository.findByConversationId(conversationId)).hasSize(1); + assertThat(chatMemoryRepository.findByConversationId(conversationId)).isEqualTo(List.of(userMessage)); - chatMemoryRepository.deleteByConversationId(conversationId); + chatMemoryRepository.deleteByConversationId(conversationId); - assertThat(chatMemoryRepository.findByConversationId(conversationId)).isEmpty(); + assertThat(chatMemoryRepository.findByConversationId(conversationId)).isEmpty(); - var multipleMessages = List.of(new UserMessage("Message from the user 1"), - new AssistantMessage("Message from the assistant 1")); + var multipleMessages = List.of(new UserMessage("Message from the user 1"), + new AssistantMessage("Message from the assistant 1")); - chatMemoryRepository.saveAll(conversationId, multipleMessages); + chatMemoryRepository.saveAll(conversationId, multipleMessages); - assertThat(chatMemoryRepository.findByConversationId(conversationId)).hasSize(multipleMessages.size()); - assertThat(chatMemoryRepository.findByConversationId(conversationId)).isEqualTo(multipleMessages); - }); + assertThat(chatMemoryRepository.findByConversationId(conversationId)).hasSize(multipleMessages.size()); + assertThat(chatMemoryRepository.findByConversationId(conversationId)).isEqualTo(multipleMessages); + }); } @Test