From 06392f90cb0cd84f01f96349c3ada6b85b8c1c74 Mon Sep 17 00:00:00 2001 From: Mark Pollack Date: Tue, 8 Oct 2024 00:10:46 +0200 Subject: [PATCH] Update azure embedding test not to set dimensions --- .../openai/AzureOpenAiEmbeddingModelObservationIT.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/models/spring-ai-azure-openai/src/test/java/org/springframework/ai/azure/openai/AzureOpenAiEmbeddingModelObservationIT.java b/models/spring-ai-azure-openai/src/test/java/org/springframework/ai/azure/openai/AzureOpenAiEmbeddingModelObservationIT.java index 002615b74..db7b05dfc 100644 --- a/models/spring-ai-azure-openai/src/test/java/org/springframework/ai/azure/openai/AzureOpenAiEmbeddingModelObservationIT.java +++ b/models/spring-ai-azure-openai/src/test/java/org/springframework/ai/azure/openai/AzureOpenAiEmbeddingModelObservationIT.java @@ -62,7 +62,9 @@ public class AzureOpenAiEmbeddingModelObservationIT { void observationForEmbeddingOperation() { var options = AzureOpenAiEmbeddingOptions.builder() .withDeploymentName("text-embedding-ada-002") - .withDimensions(1536) + // should not send dimension value? + // https://github.com/SciPhi-AI/R2R/issues/354 + // .withDimensions(1536) .build(); EmbeddingRequest embeddingRequest = new EmbeddingRequest(List.of("Here comes the sun"), options); @@ -82,7 +84,8 @@ public class AzureOpenAiEmbeddingModelObservationIT { AiOperationType.EMBEDDING.value()) .hasLowCardinalityKeyValue(LowCardinalityKeyNames.AI_PROVIDER.asString(), AiProvider.AZURE_OPENAI.value()) .hasLowCardinalityKeyValue(LowCardinalityKeyNames.REQUEST_MODEL.asString(), "text-embedding-ada-002") - .hasHighCardinalityKeyValue(HighCardinalityKeyNames.REQUEST_EMBEDDING_DIMENSIONS.asString(), "1536") + // .hasHighCardinalityKeyValue(HighCardinalityKeyNames.REQUEST_EMBEDDING_DIMENSIONS.asString(), + // "1536") .hasHighCardinalityKeyValue(HighCardinalityKeyNames.USAGE_INPUT_TOKENS.asString(), String.valueOf(responseMetadata.getUsage().getPromptTokens())) .hasHighCardinalityKeyValue(HighCardinalityKeyNames.USAGE_TOTAL_TOKENS.asString(),