From 0bcb2e138b1ae4138790275d0e58751bad76e060 Mon Sep 17 00:00:00 2001 From: Yanming Zhou Date: Wed, 14 May 2025 16:25:29 +0800 Subject: [PATCH] Fix outdated configuration key `include-completion` and `include-query-response` Fixes GH-3151 Follow-up of commit ca843e85887aa1da6300c77550c379c103500897,`includeCompletion` is renamed to `logCompletion`. Signed-off-by: Yanming Zhou --- .../autoconfigure/ChatObservationProperties.java | 12 ++++++------ .../VectorStoreObservationProperties.java | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/auto-configurations/models/chat/observation/spring-ai-autoconfigure-model-chat-observation/src/main/java/org/springframework/ai/model/chat/observation/autoconfigure/ChatObservationProperties.java b/auto-configurations/models/chat/observation/spring-ai-autoconfigure-model-chat-observation/src/main/java/org/springframework/ai/model/chat/observation/autoconfigure/ChatObservationProperties.java index 1d6c4620d..5096eb3ce 100644 --- a/auto-configurations/models/chat/observation/spring-ai-autoconfigure-model-chat-observation/src/main/java/org/springframework/ai/model/chat/observation/autoconfigure/ChatObservationProperties.java +++ b/auto-configurations/models/chat/observation/spring-ai-autoconfigure-model-chat-observation/src/main/java/org/springframework/ai/model/chat/observation/autoconfigure/ChatObservationProperties.java @@ -31,9 +31,9 @@ public class ChatObservationProperties { public static final String CONFIG_PREFIX = "spring.ai.chat.observations"; /** - * Whether to include the completion content in the observations. + * Whether to log the completion content in the observations. */ - private boolean includeCompletion = false; + private boolean logCompletion = false; /** * Whether to log the prompt content in the observations. @@ -45,12 +45,12 @@ public class ChatObservationProperties { */ private boolean includeErrorLogging = false; - public boolean isIncludeCompletion() { - return this.includeCompletion; + public boolean isLogCompletion() { + return this.logCompletion; } - public void setIncludeCompletion(boolean includeCompletion) { - this.includeCompletion = includeCompletion; + public void setLogCompletion(boolean logCompletion) { + this.logCompletion = logCompletion; } public boolean isLogPrompt() { diff --git a/auto-configurations/vector-stores/spring-ai-autoconfigure-vector-store-observation/src/main/java/org/springframework/ai/vectorstore/observation/autoconfigure/VectorStoreObservationProperties.java b/auto-configurations/vector-stores/spring-ai-autoconfigure-vector-store-observation/src/main/java/org/springframework/ai/vectorstore/observation/autoconfigure/VectorStoreObservationProperties.java index 06475cf88..3814daf9d 100644 --- a/auto-configurations/vector-stores/spring-ai-autoconfigure-vector-store-observation/src/main/java/org/springframework/ai/vectorstore/observation/autoconfigure/VectorStoreObservationProperties.java +++ b/auto-configurations/vector-stores/spring-ai-autoconfigure-vector-store-observation/src/main/java/org/springframework/ai/vectorstore/observation/autoconfigure/VectorStoreObservationProperties.java @@ -30,16 +30,16 @@ public class VectorStoreObservationProperties { public static final String CONFIG_PREFIX = "spring.ai.vectorstore.observations"; /** - * Whether to include the search response content in the observations. + * Whether to log the search response content in the observations. */ - private boolean includeQueryResponse = false; + private boolean logQueryResponse = false; - public boolean isIncludeQueryResponse() { - return this.includeQueryResponse; + public boolean isLogQueryResponse() { + return this.logQueryResponse; } - public void setIncludeQueryResponse(boolean includeQueryResponse) { - this.includeQueryResponse = includeQueryResponse; + public void setLogQueryResponse(boolean logQueryResponse) { + this.logQueryResponse = logQueryResponse; } }