Spring/spring-ai
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Checkstyle fixes

Browse Source 
Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
This commit is contained in:
Soby Chacko
2025-05-21 12:27:22 -04:00
committed by Ilayaperumal Gopinathan
parent 3068c04dca
commit 0c9d0e49fa
13 changed files with 41 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/main/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepository.java
View File

@@ -21,7 +21,6 @@ import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Timestamp;
import java.time.Instant;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.atomic.AtomicLong;
@@ -78,7 +77,7 @@ public final class JdbcChatMemoryRepository implements ChatMemoryRepository {
@Override
public List<String> findConversationIds() {
return this.jdbcTemplate.queryForList(dialect.getSelectConversationIdsSql(), String.class);
return this.jdbcTemplate.queryForList(this.dialect.getSelectConversationIdsSql(), String.class);
}
@Override

15
memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/test/java/org/springframework/ai/chat/memory/repository/jdbc/AbstractJdbcChatMemoryRepositoryIT.java
View File

@@ -41,13 +41,6 @@ import org.springframework.context.annotation.Bean;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.test.context.ContextConfiguration;
import java.sql.Timestamp;
import java.util.List;
import java.util.UUID;
import java.util.stream.Collectors;
import javax.sql.DataSource;
import static org.assertj.core.api.Assertions.assertThat;
/**
@@ -78,7 +71,7 @@ public abstract class AbstractJdbcChatMemoryRepositoryIT {
this.chatMemoryRepository.saveAll(conversationId, List.of(message));
assertThat(chatMemoryRepository.findConversationIds()).contains(conversationId);
assertThat(this.chatMemoryRepository.findConversationIds()).contains(conversationId);
// Use dialect to get the appropriate SQL query
JdbcChatMemoryRepositoryDialect dialect = JdbcChatMemoryRepositoryDialect
@@ -103,7 +96,7 @@ public abstract class AbstractJdbcChatMemoryRepositoryIT {
this.chatMemoryRepository.saveAll(conversationId, messages);
assertThat(chatMemoryRepository.findConversationIds()).contains(conversationId);
assertThat(this.chatMemoryRepository.findConversationIds()).contains(conversationId);
// Use dialect to get the appropriate SQL query
JdbcChatMemoryRepositoryDialect dialect = JdbcChatMemoryRepositoryDialect
@@ -179,10 +172,10 @@ public abstract class AbstractJdbcChatMemoryRepositoryIT {
// Save messages in the expected order
List<Message> orderedMessages = List.of(firstMessage, secondMessage, thirdMessage, fourthMessage);
chatMemoryRepository.saveAll(conversationId, orderedMessages);
this.chatMemoryRepository.saveAll(conversationId, orderedMessages);
// Retrieve messages using the repository
List<Message> retrievedMessages = chatMemoryRepository.findByConversationId(conversationId);
List<Message> retrievedMessages = this.chatMemoryRepository.findByConversationId(conversationId);
assertThat(retrievedMessages).hasSize(4);
// Get the actual order from the retrieved messages