From 36903ebf52c4b5306ecb416fe791b5ad8ce8fbee Mon Sep 17 00:00:00 2001 From: Ahoo Wang Date: Fri, 6 Jun 2025 17:19:45 +0800 Subject: [PATCH] perf(logging): optimize debug logging in PromptChatMemoryAdvisor (#3448) - Enclosed debug logging statements within an isDebugEnabled() check - Reduced unnecessary method calls and object creations when debug logging is disabled Signed-off-by: Ahoo Wang (cherry picked from commit e45b1b3f8d6fd5079ed889ad5b8687d985974268) --- .../advisor/PromptChatMemoryAdvisor.java | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/spring-ai-client-chat/src/main/java/org/springframework/ai/chat/client/advisor/PromptChatMemoryAdvisor.java b/spring-ai-client-chat/src/main/java/org/springframework/ai/chat/client/advisor/PromptChatMemoryAdvisor.java index 2f30e6c1d..de88715e8 100644 --- a/spring-ai-client-chat/src/main/java/org/springframework/ai/chat/client/advisor/PromptChatMemoryAdvisor.java +++ b/spring-ai-client-chat/src/main/java/org/springframework/ai/chat/client/advisor/PromptChatMemoryAdvisor.java @@ -157,13 +157,18 @@ public final class PromptChatMemoryAdvisor implements BaseChatMemoryAdvisor { if (!assistantMessages.isEmpty()) { this.chatMemory.add(this.getConversationId(chatClientResponse.context(), this.defaultConversationId), assistantMessages); - logger.debug("[PromptChatMemoryAdvisor.after] Added ASSISTANT messages to memory for conversationId={}: {}", - this.getConversationId(chatClientResponse.context(), this.defaultConversationId), - assistantMessages); - List memoryMessages = this.chatMemory - .get(this.getConversationId(chatClientResponse.context(), this.defaultConversationId)); - logger.debug("[PromptChatMemoryAdvisor.after] Memory after ASSISTANT add for conversationId={}: {}", - this.getConversationId(chatClientResponse.context(), this.defaultConversationId), memoryMessages); + + if (logger.isDebugEnabled()) { + logger.debug( + "[PromptChatMemoryAdvisor.after] Added ASSISTANT messages to memory for conversationId={}: {}", + this.getConversationId(chatClientResponse.context(), this.defaultConversationId), + assistantMessages); + List memoryMessages = this.chatMemory + .get(this.getConversationId(chatClientResponse.context(), this.defaultConversationId)); + logger.debug("[PromptChatMemoryAdvisor.after] Memory after ASSISTANT add for conversationId={}: {}", + this.getConversationId(chatClientResponse.context(), this.defaultConversationId), + memoryMessages); + } } return chatClientResponse; }