Spring/spring-ai
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix datasource connection leak when using the JdbcChatMemoryRepository

Browse Source 
Signed-off-by: Dan Sarlo <81384153+dsarlo-viso@users.noreply.github.com>
This commit is contained in:
Dan Sarlo
2025-05-21 15:48:01 -04:00
parent d93ab77d70
commit 560540f259
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/main/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepositoryDialect.java
View File

@@ -17,6 +17,7 @@
package org.springframework.ai.chat.memory.repository.jdbc; package org.springframework.ai.chat.memory.repository.jdbc;
import javax.sql.DataSource; import javax.sql.DataSource;
import java.sql.Connection;
/** /**
* Abstraction for database-specific SQL for chat memory repository. * Abstraction for database-specific SQL for chat memory repository.
@@ -53,8 +54,8 @@ public interface JdbcChatMemoryRepositoryDialect {
*/ */
static JdbcChatMemoryRepositoryDialect from(DataSource dataSource) { static JdbcChatMemoryRepositoryDialect from(DataSource dataSource) {
// Simple detection (could be improved) // Simple detection (could be improved)
try { try (Connection connection = dataSource.getConnection()) {
String url = dataSource.getConnection().getMetaData().getURL().toLowerCase(); String url = connection.getMetaData().getURL().toLowerCase();
if (url.contains("postgresql")) { if (url.contains("postgresql")) {
return new PostgresChatMemoryRepositoryDialect(); return new PostgresChatMemoryRepositoryDialect();
} }