From 79e2dab29ae9b78bbef8054309f6323f7d4094b0 Mon Sep 17 00:00:00 2001 From: Christian Tzolov Date: Sun, 26 May 2024 17:26:58 +0200 Subject: [PATCH] Disable ITs related to the ChatService's ChatMemory implementations Disable ITs due to deprecation of all ChatService PromptTransformer ChatMemory implementations. --- .../openai/chat/service/ChatMemoryLongTermSystemPromptIT.java | 2 ++ .../openai/chat/service/ChatMemoryShortTermMessageListIT.java | 2 ++ .../openai/chat/service/ChatMemoryShortTermSystemPromptIT.java | 2 ++ .../openai/chat/service/LongShortTermChatMemoryWithRagIT.java | 2 ++ 4 files changed, 8 insertions(+) diff --git a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryLongTermSystemPromptIT.java b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryLongTermSystemPromptIT.java index 564c0fc56..430802040 100644 --- a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryLongTermSystemPromptIT.java +++ b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryLongTermSystemPromptIT.java @@ -20,6 +20,7 @@ import java.util.List; import io.qdrant.client.QdrantClient; import io.qdrant.client.QdrantGrpcClient; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable; import org.springframework.ai.chat.service.ChatService; import org.springframework.ai.chat.service.StreamingChatService; @@ -48,6 +49,7 @@ import org.springframework.boot.SpringBootConfiguration; import org.springframework.boot.test.context.SpringBootTest; import org.springframework.context.annotation.Bean; +@Disabled("ChatService Memory implementation are deprecated. No need to test them.") @Testcontainers @SpringBootTest(classes = ChatMemoryLongTermSystemPromptIT.Config.class) @EnabledIfEnvironmentVariable(named = "OPENAI_API_KEY", matches = ".+") diff --git a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryShortTermMessageListIT.java b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryShortTermMessageListIT.java index 60489546e..b31b8a940 100644 --- a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryShortTermMessageListIT.java +++ b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryShortTermMessageListIT.java @@ -17,6 +17,7 @@ package org.springframework.ai.openai.chat.service; import java.util.List; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable; import org.springframework.ai.chat.service.ChatService; @@ -40,6 +41,7 @@ import org.springframework.boot.SpringBootConfiguration; import org.springframework.boot.test.context.SpringBootTest; import org.springframework.context.annotation.Bean; +@Disabled("ChatService Memory implementation are deprecated. No need to test them.") @SpringBootTest(classes = ChatMemoryShortTermMessageListIT.Config.class) @EnabledIfEnvironmentVariable(named = "OPENAI_API_KEY", matches = ".+") public class ChatMemoryShortTermMessageListIT extends BaseMemoryTest { diff --git a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryShortTermSystemPromptIT.java b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryShortTermSystemPromptIT.java index cc07d6da4..f3c854e5c 100644 --- a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryShortTermSystemPromptIT.java +++ b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/ChatMemoryShortTermSystemPromptIT.java @@ -18,6 +18,7 @@ package org.springframework.ai.openai.chat.service; import java.util.List; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable; import org.springframework.ai.chat.service.ChatService; @@ -41,6 +42,7 @@ import org.springframework.boot.SpringBootConfiguration; import org.springframework.boot.test.context.SpringBootTest; import org.springframework.context.annotation.Bean; +@Disabled("ChatService Memory implementation are deprecated. No need to test them.") @SpringBootTest(classes = ChatMemoryShortTermSystemPromptIT.Config.class) @EnabledIfEnvironmentVariable(named = "OPENAI_API_KEY", matches = ".+") public class ChatMemoryShortTermSystemPromptIT extends BaseMemoryTest { diff --git a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/LongShortTermChatMemoryWithRagIT.java b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/LongShortTermChatMemoryWithRagIT.java index f83b35cae..e929932c1 100644 --- a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/LongShortTermChatMemoryWithRagIT.java +++ b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/service/LongShortTermChatMemoryWithRagIT.java @@ -22,6 +22,7 @@ import java.util.Set; import io.qdrant.client.QdrantClient; import io.qdrant.client.QdrantGrpcClient; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable; import org.slf4j.Logger; @@ -73,6 +74,7 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.junit.jupiter.api.Assertions.assertTrue; import static org.springframework.ai.openai.api.OpenAiApi.ChatModel.GPT_4_TURBO_PREVIEW; +@Disabled("ChatService Memory implementation are deprecated. No need to test them.") @Testcontainers @SpringBootTest(classes = LongShortTermChatMemoryWithRagIT.Config.class) @EnabledIfEnvironmentVariable(named = "OPENAI_API_KEY", matches = ".+")