From c7512a00a7682f2208df95c067d7a51a65431c4e Mon Sep 17 00:00:00 2001 From: Christian Tzolov Date: Fri, 12 Apr 2024 08:14:59 +0200 Subject: [PATCH] Redis store: add default index and prefix values for auto-conf --- .../antora/modules/ROOT/pages/api/vectordbs/redis.adoc | 8 ++++---- .../vectorstore/redis/RedisVectorStoreProperties.java | 10 +++++----- .../redis/RedisVectorStorePropertiesTests.java | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/spring-ai-docs/src/main/antora/modules/ROOT/pages/api/vectordbs/redis.adoc b/spring-ai-docs/src/main/antora/modules/ROOT/pages/api/vectordbs/redis.adoc index 15a0167b1..7adfd60c4 100644 --- a/spring-ai-docs/src/main/antora/modules/ROOT/pages/api/vectordbs/redis.adoc +++ b/spring-ai-docs/src/main/antora/modules/ROOT/pages/api/vectordbs/redis.adoc @@ -63,7 +63,7 @@ A simple configuration can either be provided via Spring Boot's _application.pro [source,properties] ---- -spring.ai.vectorstore.redis.uri= +spring.ai.vectorstore.redis.uri= spring.ai.vectorstore.redis.index= spring.ai.vectorstore.redis.prefix= @@ -100,9 +100,9 @@ You can use the following properties in your Spring Boot configuration to custom |=== |Property| Description | Default value -|`spring.ai.vectorstore.redis.uri`| Server connection URI | redis://localhost:6379 -|`spring.ai.vectorstore.redis.index`| Index name (REQUIRED) | - -|`spring.ai.vectorstore.redis.prefix`| (REQUIRED) | - +|`spring.ai.vectorstore.redis.uri`| Server connection URI | `redis://localhost:6379` +|`spring.ai.vectorstore.redis.index`| Index name | `default-index` +|`spring.ai.vectorstore.redis.prefix`| Prefix | `default:` |=== diff --git a/spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/vectorstore/redis/RedisVectorStoreProperties.java b/spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/vectorstore/redis/RedisVectorStoreProperties.java index 7e82cf30e..705fd0cb6 100644 --- a/spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/vectorstore/redis/RedisVectorStoreProperties.java +++ b/spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/vectorstore/redis/RedisVectorStoreProperties.java @@ -27,12 +27,12 @@ public class RedisVectorStoreProperties { private String uri = "redis://localhost:6379"; - private String index; + private String index = "default-index"; - private String prefix; + private String prefix = "default:"; public String getUri() { - return uri; + return this.uri; } public void setUri(String uri) { @@ -40,7 +40,7 @@ public class RedisVectorStoreProperties { } public String getIndex() { - return index; + return this.index; } public void setIndex(String name) { @@ -48,7 +48,7 @@ public class RedisVectorStoreProperties { } public String getPrefix() { - return prefix; + return this.prefix; } public void setPrefix(String prefix) { diff --git a/spring-ai-spring-boot-autoconfigure/src/test/java/org/springframework/ai/autoconfigure/vectorstore/redis/RedisVectorStorePropertiesTests.java b/spring-ai-spring-boot-autoconfigure/src/test/java/org/springframework/ai/autoconfigure/vectorstore/redis/RedisVectorStorePropertiesTests.java index 028a51a25..14852b7e8 100644 --- a/spring-ai-spring-boot-autoconfigure/src/test/java/org/springframework/ai/autoconfigure/vectorstore/redis/RedisVectorStorePropertiesTests.java +++ b/spring-ai-spring-boot-autoconfigure/src/test/java/org/springframework/ai/autoconfigure/vectorstore/redis/RedisVectorStorePropertiesTests.java @@ -28,8 +28,8 @@ class RedisVectorStorePropertiesTests { void defaultValues() { var props = new RedisVectorStoreProperties(); assertThat(props.getUri()).isEqualTo("redis://localhost:6379"); - assertThat(props.getIndex()).isNull(); - assertThat(props.getPrefix()).isNull(); + assertThat(props.getIndex()).isEqualTo("default-index"); + assertThat(props.getPrefix()).isEqualTo("default:"); } @Test