From dfabcc7f617771409ada234f407c9ba250b3f4ec Mon Sep 17 00:00:00 2001 From: Lee-ChungMu <69577355+Lee-ChungMu@users.noreply.github.com> Date: Thu, 30 May 2024 09:54:06 +0900 Subject: [PATCH] Use List.of instead of Arrays.asList In the SEARCH_OUTPUT_FIELDS field. The Arrays.asList method can change elements. SEARCH_OUTPUT_FIELDS is an immutable field, so it has been improved to util List.of. --- .../springframework/ai/vectorstore/MilvusVectorStore.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/vector-stores/spring-ai-milvus-store/src/main/java/org/springframework/ai/vectorstore/MilvusVectorStore.java b/vector-stores/spring-ai-milvus-store/src/main/java/org/springframework/ai/vectorstore/MilvusVectorStore.java index b58cb22aa..ba113856a 100644 --- a/vector-stores/spring-ai-milvus-store/src/main/java/org/springframework/ai/vectorstore/MilvusVectorStore.java +++ b/vector-stores/spring-ai-milvus-store/src/main/java/org/springframework/ai/vectorstore/MilvusVectorStore.java @@ -16,7 +16,6 @@ package org.springframework.ai.vectorstore; import java.util.ArrayList; -import java.util.Arrays; import java.util.List; import java.util.Optional; import java.util.stream.Collectors; @@ -85,7 +84,7 @@ public class MilvusVectorStore implements VectorStore, InitializingBean { // Metadata, automatically assigned by Milvus. public static final String DISTANCE_FIELD_NAME = "distance"; - public static final List SEARCH_OUTPUT_FIELDS = Arrays.asList(DOC_ID_FIELD_NAME, CONTENT_FIELD_NAME, + public static final List SEARCH_OUTPUT_FIELDS = List.of(DOC_ID_FIELD_NAME, CONTENT_FIELD_NAME, METADATA_FIELD_NAME); public final FilterExpressionConverter filterExpressionConverter = new MilvusFilterExpressionConverter(); @@ -529,4 +528,4 @@ public class MilvusVectorStore implements VectorStore, InitializingBean { } } -} \ No newline at end of file +}