From 88c04bb557cbedfd18ace3a41c1885ecd7f23613 Mon Sep 17 00:00:00 2001 From: Artem Bilan Date: Mon, 10 Mar 2025 12:17:53 -0400 Subject: [PATCH] GH-3008: Fix `SimpleMLC.logConsumerException` for `warn` Fixes: #3008 Issue link: https://github.com/spring-projects/spring-amqp/issues/3008 The real problem in consumer (e.g. `ClassCastException` mentioned in the issue) might be lost if DEBUG logging level is not enabled * Fix the first condition in the `SimpleMessageListenerContainer.logConsumerException()` to use `logger.warn()` as it was before https://github.com/spring-projects/spring-amqp/issues/2278 fix (cherry picked from commit b55010f7423ac948c7b0d8ea92060bb0b6c86c41) --- .../amqp/rabbit/listener/SimpleMessageListenerContainer.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/SimpleMessageListenerContainer.java b/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/SimpleMessageListenerContainer.java index 06471602..8f4c293e 100644 --- a/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/SimpleMessageListenerContainer.java +++ b/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/SimpleMessageListenerContainer.java @@ -1576,7 +1576,9 @@ public class SimpleMessageListenerContainer extends AbstractMessageListenerConta private void logConsumerException(Throwable t) { if (logger.isDebugEnabled() || !(t instanceof AmqpConnectException || t instanceof ConsumerCancelledException)) { - logger.debug( + // It has to be WARN independently of condition. + // The meaning is: log WARN for all exception when DEBUG enabled, or all others, but mentioned + logger.warn( "Consumer raised exception, processing can restart if the connection factory supports it", t); }