From be3904109e1ebde4d4e65cf31fa5e00dc8f79ebe Mon Sep 17 00:00:00 2001 From: Chris Beams Date: Thu, 29 Jul 2010 17:14:38 +0200 Subject: [PATCH] Suppress serialization warnings All classes that implement java.io.Serializable are now explicitly marked with @SuppressWarnings("serial"). This serves as an indication that none of the classes are suitable for transmission across process boundaries. This may be revisited over time and as necessary the annotation may be removed in favor of a generated serialVersionUID. Until such time, there Spring AMQP maintains no serialization compatibility guarantees for any class so annotated. --- .../src/main/java/org/springframework/amqp/AmqpException.java | 1 + .../main/java/org/springframework/amqp/AmqpIOException.java | 1 + .../org/springframework/amqp/AmqpIllegalStateException.java | 1 + .../springframework/amqp/AmqpUnsupportedEncodingException.java | 1 + .../org/springframework/amqp/UncategorizedAmqpException.java | 1 + .../amqp/support/converter/MessageConversionException.java | 1 + .../org/springframework/amqp/rabbit/stocks/ui/StockPanel.java | 1 + .../java/org/springframework/erlang/ErlangBadRpcException.java | 1 + .../org/springframework/erlang/ErlangErrorRpcException.java | 3 ++- .../main/java/org/springframework/erlang/OtpAuthException.java | 1 + .../src/main/java/org/springframework/erlang/OtpException.java | 1 + .../main/java/org/springframework/erlang/OtpIOException.java | 1 + .../org/springframework/erlang/UncategorizedOtpException.java | 1 + .../erlang/support/converter/ErlangConversionException.java | 1 + .../amqp/rabbit/listener/AbstractMessageListenerContainer.java | 1 + .../amqp/rabbit/listener/AbstractRabbitListeningContainer.java | 1 + .../listener/adapter/ListenerExecutionFailedException.java | 1 + 17 files changed, 18 insertions(+), 1 deletion(-) diff --git a/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpException.java b/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpException.java index b2482301..d38e397c 100644 --- a/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpException.java +++ b/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpException.java @@ -21,6 +21,7 @@ package org.springframework.amqp; * * @author Mark Fisher */ +@SuppressWarnings("serial") public class AmqpException extends RuntimeException { public AmqpException(String message) { diff --git a/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpIOException.java b/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpIOException.java index 56cc202c..cc8bc408 100644 --- a/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpIOException.java +++ b/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpIOException.java @@ -24,6 +24,7 @@ import java.io.IOException; * * @author Mark Pollack */ +@SuppressWarnings("serial") public class AmqpIOException extends AmqpException { public AmqpIOException(IOException cause) { diff --git a/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpIllegalStateException.java b/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpIllegalStateException.java index c7b2bbf5..f121084a 100644 --- a/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpIllegalStateException.java +++ b/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpIllegalStateException.java @@ -21,6 +21,7 @@ package org.springframework.amqp; * * @author Mark Pollack */ +@SuppressWarnings("serial") public class AmqpIllegalStateException extends AmqpException { public AmqpIllegalStateException(String message) { diff --git a/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpUnsupportedEncodingException.java b/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpUnsupportedEncodingException.java index 0e89487b..d65907c5 100644 --- a/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpUnsupportedEncodingException.java +++ b/spring-amqp-core/src/main/java/org/springframework/amqp/AmqpUnsupportedEncodingException.java @@ -21,6 +21,7 @@ package org.springframework.amqp; * * @author Mark Pollack */ +@SuppressWarnings("serial") public class AmqpUnsupportedEncodingException extends AmqpException { public AmqpUnsupportedEncodingException(Throwable cause) { diff --git a/spring-amqp-core/src/main/java/org/springframework/amqp/UncategorizedAmqpException.java b/spring-amqp-core/src/main/java/org/springframework/amqp/UncategorizedAmqpException.java index c50bdb21..e58b7d53 100644 --- a/spring-amqp-core/src/main/java/org/springframework/amqp/UncategorizedAmqpException.java +++ b/spring-amqp-core/src/main/java/org/springframework/amqp/UncategorizedAmqpException.java @@ -22,6 +22,7 @@ package org.springframework.amqp; * * @author Mark Pollack */ +@SuppressWarnings("serial") public class UncategorizedAmqpException extends AmqpException { public UncategorizedAmqpException(Throwable cause) { diff --git a/spring-amqp-core/src/main/java/org/springframework/amqp/support/converter/MessageConversionException.java b/spring-amqp-core/src/main/java/org/springframework/amqp/support/converter/MessageConversionException.java index 0402817e..a0908506 100644 --- a/spring-amqp-core/src/main/java/org/springframework/amqp/support/converter/MessageConversionException.java +++ b/spring-amqp-core/src/main/java/org/springframework/amqp/support/converter/MessageConversionException.java @@ -21,6 +21,7 @@ import org.springframework.amqp.AmqpException; /** * @author Mark Fisher */ +@SuppressWarnings("serial") public class MessageConversionException extends AmqpException { public MessageConversionException(String message, Throwable cause) { diff --git a/spring-amqp-samples/stocks/src/main/java/org/springframework/amqp/rabbit/stocks/ui/StockPanel.java b/spring-amqp-samples/stocks/src/main/java/org/springframework/amqp/rabbit/stocks/ui/StockPanel.java index 66626fa1..7e47ccf9 100644 --- a/spring-amqp-samples/stocks/src/main/java/org/springframework/amqp/rabbit/stocks/ui/StockPanel.java +++ b/spring-amqp-samples/stocks/src/main/java/org/springframework/amqp/rabbit/stocks/ui/StockPanel.java @@ -49,6 +49,7 @@ import com.jgoodies.forms.layout.FormLayout; * @author Mark Pollack * @author Mark Fisher */ +@SuppressWarnings("serial") public class StockPanel extends JPanel { private static Log log = LogFactory.getLog(StockPanel.class); diff --git a/spring-erlang/src/main/java/org/springframework/erlang/ErlangBadRpcException.java b/spring-erlang/src/main/java/org/springframework/erlang/ErlangBadRpcException.java index 8c8ecf63..0ee99c33 100644 --- a/spring-erlang/src/main/java/org/springframework/erlang/ErlangBadRpcException.java +++ b/spring-erlang/src/main/java/org/springframework/erlang/ErlangBadRpcException.java @@ -22,6 +22,7 @@ import com.ericsson.otp.erlang.OtpErlangTuple; * @author Mark Pollack * */ +@SuppressWarnings("serial") public class ErlangBadRpcException extends OtpException { private OtpErlangTuple reasonTuple; diff --git a/spring-erlang/src/main/java/org/springframework/erlang/ErlangErrorRpcException.java b/spring-erlang/src/main/java/org/springframework/erlang/ErlangErrorRpcException.java index 4c0ff139..dd0c72f3 100644 --- a/spring-erlang/src/main/java/org/springframework/erlang/ErlangErrorRpcException.java +++ b/spring-erlang/src/main/java/org/springframework/erlang/ErlangErrorRpcException.java @@ -19,9 +19,10 @@ import com.ericsson.otp.erlang.OtpErlangTuple; /** * Exception thrown when an 'error' is received from an Erlang RPC call - * @author Mark Pollack * + * @author Mark Pollack */ +@SuppressWarnings("serial") public class ErlangErrorRpcException extends OtpException { private OtpErlangTuple reasonTuple; diff --git a/spring-erlang/src/main/java/org/springframework/erlang/OtpAuthException.java b/spring-erlang/src/main/java/org/springframework/erlang/OtpAuthException.java index 5531406c..04535bc6 100644 --- a/spring-erlang/src/main/java/org/springframework/erlang/OtpAuthException.java +++ b/spring-erlang/src/main/java/org/springframework/erlang/OtpAuthException.java @@ -21,6 +21,7 @@ package org.springframework.erlang; * * @author Mark Pollack */ +@SuppressWarnings("serial") public class OtpAuthException extends OtpException { public OtpAuthException(com.ericsson.otp.erlang.OtpAuthException cause) { diff --git a/spring-erlang/src/main/java/org/springframework/erlang/OtpException.java b/spring-erlang/src/main/java/org/springframework/erlang/OtpException.java index e9de7955..d1c69776 100644 --- a/spring-erlang/src/main/java/org/springframework/erlang/OtpException.java +++ b/spring-erlang/src/main/java/org/springframework/erlang/OtpException.java @@ -21,6 +21,7 @@ package org.springframework.erlang; * * @author Mark Pollack */ +@SuppressWarnings("serial") public class OtpException extends RuntimeException { public OtpException(String message) { diff --git a/spring-erlang/src/main/java/org/springframework/erlang/OtpIOException.java b/spring-erlang/src/main/java/org/springframework/erlang/OtpIOException.java index 7443045f..43e63944 100644 --- a/spring-erlang/src/main/java/org/springframework/erlang/OtpIOException.java +++ b/spring-erlang/src/main/java/org/springframework/erlang/OtpIOException.java @@ -25,6 +25,7 @@ import java.io.IOException; * @author Mark Pollack * @author Mark Fisher */ +@SuppressWarnings("serial") public class OtpIOException extends OtpException { public OtpIOException(IOException cause) { diff --git a/spring-erlang/src/main/java/org/springframework/erlang/UncategorizedOtpException.java b/spring-erlang/src/main/java/org/springframework/erlang/UncategorizedOtpException.java index b6a3310f..17677f5b 100644 --- a/spring-erlang/src/main/java/org/springframework/erlang/UncategorizedOtpException.java +++ b/spring-erlang/src/main/java/org/springframework/erlang/UncategorizedOtpException.java @@ -22,6 +22,7 @@ package org.springframework.erlang; * * @author Mark Pollack */ +@SuppressWarnings("serial") public class UncategorizedOtpException extends OtpException { public UncategorizedOtpException(Throwable cause) { diff --git a/spring-erlang/src/main/java/org/springframework/erlang/support/converter/ErlangConversionException.java b/spring-erlang/src/main/java/org/springframework/erlang/support/converter/ErlangConversionException.java index 83ee4382..50195eab 100644 --- a/spring-erlang/src/main/java/org/springframework/erlang/support/converter/ErlangConversionException.java +++ b/spring-erlang/src/main/java/org/springframework/erlang/support/converter/ErlangConversionException.java @@ -21,6 +21,7 @@ import org.springframework.erlang.OtpException; /** * @author Mark Pollack */ +@SuppressWarnings("serial") public class ErlangConversionException extends OtpException { public ErlangConversionException(String message, Throwable cause) { diff --git a/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/AbstractMessageListenerContainer.java b/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/AbstractMessageListenerContainer.java index 5c52fb40..6c268c96 100644 --- a/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/AbstractMessageListenerContainer.java +++ b/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/AbstractMessageListenerContainer.java @@ -426,6 +426,7 @@ public abstract class AbstractMessageListenerContainer extends AbstractRabbitLis * Internal exception class that indicates a rejected message on shutdown. * Used to trigger a rollback for an external transaction manager in that case. */ + @SuppressWarnings("serial") private static class MessageRejectedWhileStoppingException extends RuntimeException { } diff --git a/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/AbstractRabbitListeningContainer.java b/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/AbstractRabbitListeningContainer.java index f50562db..7cc2b009 100644 --- a/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/AbstractRabbitListeningContainer.java +++ b/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/AbstractRabbitListeningContainer.java @@ -413,6 +413,7 @@ public abstract class AbstractRabbitListeningContainer extends RabbitAccessor im * shared Rabbit Connection failed. This is indicating to invokers that they need * to establish the shared Connection themselves on first access. */ + @SuppressWarnings("serial") public static class SharedConnectionNotInitializedException extends RuntimeException { /** diff --git a/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/adapter/ListenerExecutionFailedException.java b/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/adapter/ListenerExecutionFailedException.java index 762f1429..0acbe788 100644 --- a/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/adapter/ListenerExecutionFailedException.java +++ b/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/adapter/ListenerExecutionFailedException.java @@ -26,6 +26,7 @@ import org.springframework.amqp.AmqpException; * @since 2.0 * @see MessageListenerAdapter */ +@SuppressWarnings("serial") public class ListenerExecutionFailedException extends AmqpException { /**