Gary Russell
7367bd7457
Always Remove Test Exchanges in ERIT
...
- in case of dross left behind by a failed test run
2020-07-14 13:35:05 -04:00
Artem Bilan
4ac89e4701
Fix BrokerRunning for skipping tests
...
The regression after https://github.com/spring-projects/spring-amqp/issues/1190
The `assumeNoException(e)` was missed in the `BrokerRunning`
when we don't have a locally ran RabbitMQ and no requirement.
With the `assumeNoException(e)` test are skipped with positive
outcome
**Cherry-pick to `2.2.x`**
2020-05-26 16:14:07 -04:00
Gary Russell
4180b9289f
Remove unused import
2020-05-06 11:21:32 -04:00
Gary Russell
cc7270c190
GH-1190: Remove reference to Junit4 Assume
...
Resolves https://github.com/spring-projects/spring-amqp/issues/1190
- Remove reference to `Assume` in `BrokerRunningSupport`
- Move example test cases to a new package so they can be easily copied/pasted
- Remove `assumeOnline` field - it looks like it was intended to support running
tests only if RabbitMQ is NOT running; but there was never any way to set it
to false
**cherry-pick to 2.2.x**
2020-05-05 13:34:00 -04:00
Gary Russell
f85a3849fc
GH-1175: Add @SpringRabbitTest
...
Resolves https://github.com/spring-projects/spring-amqp/issues/1175
- provision boilerplate infrastructure
* Fix test name in doc
* Remove `@ContextConfiguration` from doc.
2020-03-13 11:15:24 -04:00
Gary Russell
ddccc08bdc
Remove deprecations; fix corresponding schema
...
- add `batch-size`
- deprecate `transaction-size`
- remove deprecated `publisher-confirms`
- add 'consumer-batch-enabled'
2020-03-10 14:06:09 -04:00
Gary Russell
0695d05042
Remove super()
2019-12-27 13:03:20 -05:00
Gary Russell
1fed5a7443
Fix Sonar issues in deprecated RepeatProcessor
2019-08-23 09:11:33 -04:00
Gary Russell
868979d9a4
Convert remaining spring-rabbit tests to JUnit 5
...
* Fix possible race in testConsumerBatching
* Convert all spring-amqp tests to JUnit 5
* Convert remaining tests to JUnit 5; remove JUnit 4 test dependency
* Remove JUnit vintage engine dependency
2019-08-22 16:31:58 -04:00
Gary Russell
4b19b61d1e
Convert repeated tests to JUnit 5 @RepeatableTest
...
- add lifecycle to `@LogLevels` to avoid adjusting the log on each iteration
- with `@RepeatableTest` there is a template context between the class and method contexts
* * Remove Lifecycle from `@LogLevels`
* Only apply levels once for a class-level annotation
* Log a new delimiter between tests when using a class-level annotation
* Only log one delimiter per test method (e.g. when `@RepeatedTest`)
2019-08-21 17:43:31 -04:00
Gary Russell
28e91034d6
GH-1071: Retain stacktrace when broker required
2019-08-21 09:04:13 -04:00
Gary Russell
958806a88f
GH-1071: Retain stacktrace when broker required
2019-08-21 09:00:48 -04:00
Gary Russell
50c17ea0e0
GH-1071: JUnit 5 Support Improvements
...
Resolves https://github.com/spring-projects/spring-amqp/issues/1071
- Remove JUnit4 dependency from `RabbitAvailableCondition` (minor breaking API change)
- Add `purgeAfterEach` to `@RabbitAvailable`
- tabs not spaces in `RabbitAvailableCondition` (review with `?w=1`)
- `@LogLevels` now requires `level`
* Sonar, javadoc fixes; default log level, per review comments; convert more tests.
* Remove unnecessary `defaultPort` field; 2 more conversions
2019-08-20 20:30:57 -04:00
Gary Russell
bbc4ebabb4
Fix @LogLevels copyright, javadoc
2019-08-16 10:22:01 -04:00
Artem Bilan
594ba7c1bb
Fix new Sonar smells
2019-08-16 09:17:43 -04:00
Gary Russell
2c5d0374f8
Convert more tests to JUnit5
...
- some low-hanging fruit
- speed up admin tests with declaration failures with a `NoBackoffPolicy` or remove retry altogether
- speed up some tests that were waiting 2 seconds for no message expected
- Polishing Queue.clone()
- decouple `LongRunningIntegrationTestCondition` from JUnit 4
- Add JUnit 5 log level adjuster; find @RabbitAvailable etc on test superclasses
- Support @LogLevels at the method level
- Make JUnit 4 an optional dependency
- Remove annotation from method level context store
- Fix typo in class name
- Fix @since
Javadoc
- Switch to the new Log4j2 logic from Spring Integration
2019-08-15 13:29:55 -04:00
Gary Russell
11f20765e3
Fix Sonar problems
2019-06-06 10:43:20 -04:00
Gary Russell
7472f1b0b6
Convert tests to AssertJ
...
- initial automated conversion + polishing
- TODO: `...size()).isEqualTo(...` to `).hasSize(...` etc
2019-04-16 13:16:32 -04:00
Artem Bilan
1614a4b053
URL Cleanup
...
This commit updates URLs to prefer the https protocol.
Redirects are not followed to avoid accidentally expanding intentionally
shortened URLs (i.e. if using a URL shortener).
# Fixed URLs
## Fixed Success
These URLs were switched to an https URL with a 2xx status.
While the status was successful, your review is still recommended.
* [ ] http://www.apache.org/licenses/ with 1 occurrences migrated to:
https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/ ) result 200).
* [ ] http://www.apache.org/licenses/LICENSE-2.0 with 433 occurrences migrated to:
https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0 ) result 200).
2019-03-22 17:28:13 -04:00
Artem Bilan
04d014aa9b
Fix BrokerRunningTest back to http for management
...
https://build.spring.io/browse/AMQP-MASTER-1059/
2019-03-20 21:24:08 -04:00
Spring Operator
660df5e33e
URL Cleanup
...
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
# Fixed URLs
## Fixed But Review Recommended
These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended.
* [ ] http://baz:15672/api/ (UnknownHostException) with 1 occurrences migrated to:
https://baz:15672/api/ ([https](https://baz:15672/api/ ) result UnknownHostException).
* [ ] http://foo/bar (UnknownHostException) with 2 occurrences migrated to:
https://foo/bar ([https](https://foo/bar ) result UnknownHostException).
* [ ] http://host1:15672 (UnknownHostException) with 1 occurrences migrated to:
https://host1:15672 ([https](https://host1:15672 ) result UnknownHostException).
* [ ] http://host2:15672 (UnknownHostException) with 1 occurrences migrated to:
https://host2:15672 ([https](https://host2:15672 ) result UnknownHostException).
* [ ] http://host:port (UnknownHostException) with 4 occurrences migrated to:
https://host:port ([https](https://host:port ) result UnknownHostException).
## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.
* [ ] http://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project with 1 occurrences migrated to:
https://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project ([https](https://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project ) result 200).
* [ ] http://git-scm.com/book/en/Git-Branching-Rebasing with 2 occurrences migrated to:
https://git-scm.com/book/en/Git-Branching-Rebasing ([https](https://git-scm.com/book/en/Git-Branching-Rebasing ) result 200).
* [ ] http://github.com/SpringSource/spring-amqp with 1 occurrences migrated to:
https://github.com/SpringSource/spring-amqp ([https](https://github.com/SpringSource/spring-amqp ) result 200).
* [ ] http://github.com/SpringSource/spring-amqp-samples with 1 occurrences migrated to:
https://github.com/SpringSource/spring-amqp-samples ([https](https://github.com/SpringSource/spring-amqp-samples ) result 200).
* [ ] http://github.com/spring-projects/spring-amqp with 1 occurrences migrated to:
https://github.com/spring-projects/spring-amqp ([https](https://github.com/spring-projects/spring-amqp ) result 200).
* [ ] http://github.com/spring-projects/spring-amqp-samples with 1 occurrences migrated to:
https://github.com/spring-projects/spring-amqp-samples ([https](https://github.com/spring-projects/spring-amqp-samples ) result 200).
* [ ] http://gradle.org/ with 2 occurrences migrated to:
https://gradle.org/ ([https](https://gradle.org/ ) result 200).
* [ ] http://projects.spring.io/spring-amqp/ with 2 occurrences migrated to:
https://projects.spring.io/spring-amqp/ ([https](https://projects.spring.io/spring-amqp/ ) result 200).
* [ ] http://stackoverflow.com/questions/tagged/spring-amqp with 3 occurrences migrated to:
https://stackoverflow.com/questions/tagged/spring-amqp ([https](https://stackoverflow.com/questions/tagged/spring-amqp ) result 200).
* [ ] http://www.amqp.org/ with 1 occurrences migrated to:
https://www.amqp.org/ ([https](https://www.amqp.org/ ) result 200).
* [ ] http://www.amqp.org/resources/download with 1 occurrences migrated to:
https://www.amqp.org/resources/download ([https](https://www.amqp.org/resources/download ) result 200).
* [ ] http://www.rabbitmq.com/ with 2 occurrences migrated to:
https://www.rabbitmq.com/ ([https](https://www.rabbitmq.com/ ) result 200).
* [ ] http://www.rabbitmq.com/blog/2011/02/10/introducing-publisher-confirms/ with 1 occurrences migrated to:
https://www.rabbitmq.com/blog/2011/02/10/introducing-publisher-confirms/ ([https](https://www.rabbitmq.com/blog/2011/02/10/introducing-publisher-confirms/ ) result 200).
* [ ] http://www.rabbitmq.com/blog/2013/12/16/using-consumer-priorities-with-rabbitmq/ with 1 occurrences migrated to:
https://www.rabbitmq.com/blog/2013/12/16/using-consumer-priorities-with-rabbitmq/ ([https](https://www.rabbitmq.com/blog/2013/12/16/using-consumer-priorities-with-rabbitmq/ ) result 200).
* [ ] http://www.rabbitmq.com/direct-reply-to.html with 3 occurrences migrated to:
https://www.rabbitmq.com/direct-reply-to.html ([https](https://www.rabbitmq.com/direct-reply-to.html ) result 200).
* [ ] http://www.rabbitmq.com/download.html with 2 occurrences migrated to:
https://www.rabbitmq.com/download.html ([https](https://www.rabbitmq.com/download.html ) result 200).
* [ ] http://www.rabbitmq.com/how.html with 1 occurrences migrated to:
https://www.rabbitmq.com/how.html ([https](https://www.rabbitmq.com/how.html ) result 200).
* [ ] http://www.rabbitmq.com/install.html with 1 occurrences migrated to:
https://www.rabbitmq.com/install.html ([https](https://www.rabbitmq.com/install.html ) result 200).
* [ ] http://www.rabbitmq.com/semantics.html with 1 occurrences migrated to:
https://www.rabbitmq.com/semantics.html ([https](https://www.rabbitmq.com/semantics.html ) result 200).
* [ ] http://www.rabbitmq.com/ttl.html with 1 occurrences migrated to:
https://www.rabbitmq.com/ttl.html ([https](https://www.rabbitmq.com/ttl.html ) result 200).
* [ ] http://www.rabbitmq.com/tutorials/tutorial-six-java.html with 1 occurrences migrated to:
https://www.rabbitmq.com/tutorials/tutorial-six-java.html ([https](https://www.rabbitmq.com/tutorials/tutorial-six-java.html ) result 200).
* [ ] http://www.sonarsource.org/ (301) with 2 occurrences migrated to:
https://www.sonarqube.org/ ([https](https://www.sonarsource.org/ ) result 200).
* [ ] http://www.springframework.org/schema/beans/spring-beans.xsd with 1 occurrences migrated to:
https://www.springframework.org/schema/beans/spring-beans.xsd ([https](https://www.springframework.org/schema/beans/spring-beans.xsd ) result 200).
* [ ] http://contributor-covenant.org with 1 occurrences migrated to:
https://contributor-covenant.org ([https](https://contributor-covenant.org ) result 301).
* [ ] http://contributor-covenant.org/version/1/3/0/ with 1 occurrences migrated to:
https://contributor-covenant.org/version/1/3/0/ ([https](https://contributor-covenant.org/version/1/3/0/ ) result 301).
* [ ] http://docs.spring.io/spring-amqp/docs/current/api/index.html?org/springframework/amqp/support/converter/DefaultClassMapper.html with 1 occurrences migrated to:
https://docs.spring.io/spring-amqp/docs/current/api/index.html?org/springframework/amqp/support/converter/DefaultClassMapper.html ([https](https://docs.spring.io/spring-amqp/docs/current/api/index.html?org/springframework/amqp/support/converter/DefaultClassMapper.html ) result 301).
* [ ] http://docs.spring.io/spring-amqp/docs/latest-ga/api/org/springframework/amqp/core/MessageProperties.html with 1 occurrences migrated to:
https://docs.spring.io/spring-amqp/docs/latest-ga/api/org/springframework/amqp/core/MessageProperties.html ([https](https://docs.spring.io/spring-amqp/docs/latest-ga/api/org/springframework/amqp/core/MessageProperties.html ) result 301).
* [ ] http://static.springsource.org/spring-amqp/docs/latest_ga/api/org/springframework/amqp/rabbit/core/RabbitTemplate.html (301) with 1 occurrences migrated to:
https://docs.spring.io/spring-amqp/docs/latest_ga/api/org/springframework/amqp/rabbit/core/RabbitTemplate.html ([https](https://static.springsource.org/spring-amqp/docs/latest_ga/api/org/springframework/amqp/rabbit/core/RabbitTemplate.html ) result 301).
* [ ] http://static.springsource.org/spring-amqp/docs/latest_ga/api/org/springframework/amqp/rabbit/transaction/RabbitTransactionManager.html (301) with 1 occurrences migrated to:
https://docs.spring.io/spring-amqp/docs/latest_ga/api/org/springframework/amqp/rabbit/transaction/RabbitTransactionManager.html ([https](https://static.springsource.org/spring-amqp/docs/latest_ga/api/org/springframework/amqp/rabbit/transaction/RabbitTransactionManager.html ) result 301).
* [ ] http://docs.spring.io/spring-amqp/reference/ with 1 occurrences migrated to:
https://docs.spring.io/spring-amqp/reference/ ([https](https://docs.spring.io/spring-amqp/reference/ ) result 301).
* [ ] http://static.springsource.org/spring-amqp/reference/html/amqp.html (301) with 2 occurrences migrated to:
https://docs.spring.io/spring-amqp/reference/html/amqp.html ([https](https://static.springsource.org/spring-amqp/reference/html/amqp.html ) result 301).
* [ ] http://docs.spring.io/spring-framework/docs/current/spring-framework-reference/html/transaction.html with 1 occurrences migrated to:
https://docs.spring.io/spring-framework/docs/current/spring-framework-reference/html/transaction.html ([https](https://docs.spring.io/spring-framework/docs/current/spring-framework-reference/html/transaction.html ) result 301).
* [ ] http://static.springsource.org/spring-retry/docs/api/current/ (301) with 1 occurrences migrated to:
https://docs.spring.io/spring-retry/docs/api/current/ ([https](https://static.springsource.org/spring-retry/docs/api/current/ ) result 301).
* [ ] http://static.springsource.org/spring/docs/current/javadoc-api/org/springframework/transaction/PlatformTransactionManager.html (301) with 1 occurrences migrated to:
https://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/transaction/PlatformTransactionManager.html ([https](https://static.springsource.org/spring/docs/current/javadoc-api/org/springframework/transaction/PlatformTransactionManager.html ) result 301).
* [ ] http://docs.spring.io/spring/docs/current/spring-framework-reference/html/beans.html with 1 occurrences migrated to:
https://docs.spring.io/spring/docs/current/spring-framework-reference/html/beans.html ([https](https://docs.spring.io/spring/docs/current/spring-framework-reference/html/beans.html ) result 301).
* [ ] http://docs.spring.io/spring/docs/current/spring-framework-reference/html/oxm.html with 1 occurrences migrated to:
https://docs.spring.io/spring/docs/current/spring-framework-reference/html/oxm.html ([https](https://docs.spring.io/spring/docs/current/spring-framework-reference/html/oxm.html ) result 301).
* [ ] http://static.springsource.org/spring/docs/current/spring-framework-reference/html/remoting.html (301) with 1 occurrences migrated to:
https://docs.spring.io/spring/docs/current/spring-framework-reference/html/remoting.html ([https](https://static.springsource.org/spring/docs/current/spring-framework-reference/html/remoting.html ) result 301).
* [ ] http://docs.spring.io/spring/docs/current/spring-framework-reference/html/scheduling.html with 1 occurrences migrated to:
https://docs.spring.io/spring/docs/current/spring-framework-reference/html/scheduling.html ([https](https://docs.spring.io/spring/docs/current/spring-framework-reference/html/scheduling.html ) result 301).
* [ ] http://static.springsource.org/sts/docs/latest/reference/html/gradle/installation.html (301) with 2 occurrences migrated to:
https://docs.spring.io/sts/docs/latest/reference/html/gradle/installation.html ([https](https://static.springsource.org/sts/docs/latest/reference/html/gradle/installation.html ) result 301).
* [ ] http://forum.springsource.org/forumdisplay.php?f=74 (301) with 2 occurrences migrated to:
https://forum.spring.io/ ([https](https://forum.springsource.org/forumdisplay.php?f=74 ) result 301).
* [ ] http://help.github.com/fork-a-repo/ with 1 occurrences migrated to:
https://help.github.com/fork-a-repo/ ([https](https://help.github.com/fork-a-repo/ ) result 301).
* [ ] http://help.github.com/forking/ with 2 occurrences migrated to:
https://help.github.com/forking/ ([https](https://help.github.com/forking/ ) result 301).
* [ ] http://www.spring.io with 2 occurrences migrated to:
https://www.spring.io ([https](https://www.spring.io ) result 301).
* [ ] http://www.spring.io/spring-amqp with 1 occurrences migrated to:
https://www.spring.io/spring-amqp ([https](https://www.spring.io/spring-amqp ) result 301).
* [ ] http://www.springframework.org/schema/rabbit/spring-rabbit.xsd with 1 occurrences migrated to:
https://www.springframework.org/schema/rabbit/spring-rabbit.xsd ([https](https://www.springframework.org/schema/rabbit/spring-rabbit.xsd ) result 301).
* [ ] http://www.springsource.org/spring-amqp with 1 occurrences migrated to:
https://www.springsource.org/spring-amqp ([https](https://www.springsource.org/spring-amqp ) result 301).
* [ ] http://www.springsource.org/spring-integration with 1 occurrences migrated to:
https://www.springsource.org/spring-integration ([https](https://www.springsource.org/spring-integration ) result 301).
* [ ] http://www.springsource.org/sts with 1 occurrences migrated to:
https://www.springsource.org/sts ([https](https://www.springsource.org/sts ) result 301).
* [ ] http://projectreactor.io/docs/netty/release/reference/docs/index.html with 1 occurrences migrated to:
https://projectreactor.io/docs/netty/release/reference/docs/index.html ([https](https://projectreactor.io/docs/netty/release/reference/docs/index.html ) result 302).
* [ ] http://www.springsource.org/node/feed with 2 occurrences migrated to:
https://www.springsource.org/node/feed ([https](https://www.springsource.org/node/feed ) result 302).
# Ignored
These URLs were intentionally ignored.
* http://guest:guest@localhost:15672/api with 1 occurrences
* http://guest:guest@localhost:15672/api/ with 1 occurrences
* http://localhost:11235 with 2 occurrences
* http://localhost:11236 with 2 occurrences
* http://localhost:15672 with 2 occurrences
* http://localhost:15672/api/ with 6 occurrences
* http://www.springframework.org/schema/beans with 4 occurrences
* http://www.springframework.org/schema/rabbit with 6 occurrences
* http://www.springframework.org/schema/tool with 2 occurrences
* http://www.w3.org/2001/XMLSchema with 1 occurrences
* http://www.w3.org/2001/XMLSchema-instance with 2 occurrences
2019-03-20 18:07:16 -04:00
Gary Russell
6ba27ee97d
Sonar Fixes
...
- all minors
* Remaining issues - mostly imports for Javadocs only.
* Final final
* Polising - bogus chars in comment
* Polishing idle time.
2018-12-23 12:27:04 -05:00
Artem Bilan
dda3adaaf3
Fix javadoc according Checkstyle
2018-11-29 16:45:44 -05:00
Artem Bilan
68b770c369
Checkstyle: Add Javadoc to BrokerNotAliveException
...
https://build.spring.io/browse/AMQP-MASTER-986/
2018-11-29 16:29:42 -05:00
Gary Russell
52cb146c19
Sonar Fixes
...
* Polishing - PR Comments
2018-11-29 16:19:48 -05:00
Gary Russell
8bf38449b9
More Sonar Fixes
2018-10-26 11:44:47 -04:00
Artem Bilan
d316dbf6c8
Upgrade to SF-5.1, remove deprecations etc.
...
* Upgrade to SF-5.1, Log4J-2.11, Mockito-2.17, Jackson 2.9.5,
SonarQube-2.6.1, Checkstyle-8.8
* Remove `spring-io-plugin` since it's not going to exist after Cairo
release
* Move `log4j-slf4j-impl` to the modules where no `logback-classic`
dependency - the `logback` performs expected work for us via
`spring-rabbit` infrastructure
* `log4j2-test.xml` in the `spring-rabbit-junit` to the `test` scope
* Remove some old `@Deprecated` API
2018-04-04 17:16:55 -04:00
Gary Russell
822593b767
Fix JUnit dependencies
...
- eliminate the `platform-commons` dependency
- make the `jupiter-api` dependency optional
2017-12-21 13:48:34 -05:00
Gary Russell
d73f4ffc0a
AMQP-791: Support JUnit5
...
JIRA: https://jira.spring.io/browse/AMQP-791
- refactor `BrokerRunning` JUnit4 `@Rule` so it can be invoked from an `ExecutionCondition`.
- Add `@RabbitAvailable` annotation with queue list and auto-delete queues at the end of the class; purge them between tests.
* Implement `ParameterResolver` to access the rule's connection factory.
* Support CTOR Injection and `BrokerRunning` Injection
- user might want to invoke methods such as `deleteQueues()`.
* Patches omitted from previous commit
* WIP - Spring
* Polishing - PR Comments
* Convert `RabbitTemplateMPPIntegrationTests` - JUnit5
* Remove bogus test
* Docs + `@LongRunning`
* Polishing - PR Comments
2017-12-20 14:43:35 -05:00
Gary Russell
c576b27493
AMQP-790: Fix after receive MPPs with send/receive
...
JIRA: https://jira.spring.io/browse/AMQP-790
Previously, `afterReceivePostProcessors` were not called on `sendAndReceive()`
operations.
2017-12-12 11:06:41 -08:00
Gary Russell
38f38c4d35
AMQP-728: Make BrokerRunning More Configurable
...
JIRA: https://jira.spring.io/browse/AMQP-728
Resolves : #592
Add more options to configure the `BrokerRunning` JUnit `@Rule`.
Fix missing exclude from build.gradle for the junit subproject.
Polishing - PR Comments
More Polishing
**Cherry-pick to 1.7.x**
2017-03-16 15:34:38 -04:00
Gary Russell
c22ba9fdf3
CheckStyle: JavaDoc
2017-02-27 15:27:19 -05:00
Gary Russell
00828bc1ee
Polish BrokerRunning @Rule
...
- Improve Javadocs
- Fail fast when broker required and don't log the full stack trace
2017-02-21 10:41:28 -05:00
Gary Russell
3b1b21f57e
BrokerRunning Sonar Fixes
2016-12-07 11:39:47 -05:00
Gary Russell
4fded3dde1
AMQP-678: Move BrokerRunning @Rule to junit Jar
...
JIRA: https://jira.spring.io/browse/AMQP-678
Convert `BrokerRunning` to use the amqp-client directly to avoid circular reference.
Also `LongRunningIntegrationTest`.
Polishing - PR Comments
2016-12-02 15:05:09 -05:00