Commit Graph

6 Commits

Author SHA1 Message Date
Gary Russell
b507597f48 GH-1309: Don't Bind Resource When Sync Not Active
Resolves https://github.com/spring-projects/spring-amqp/issues/1309

If the `RabbitTemplate` was called from a `@TransactionalEventListener`,
with phase `AFTER_COMMIT`, a transaction is "active", but synchronizations
are already cleared. It is too late to synchronize this transaction.

We end up with an orphaned `ResourceHolder` with pending transaction commits.

Don't bind the resource holder if synchronization is not active.

However, the proper solution, if users want to synchronize the rabbit transaction
with the global transaction, is to use the `BEFORE_COMMIT` phase.

See the discussion on the Github issue for more information.

**cherry-pick to 2.2.x**

* Fix since version.

* Reset physical close required flag left over from another test.

* Capture test results for all modules.
2021-03-16 11:26:55 -04:00
Gary Russell
b623a9e147 Capture test results in PR workflow. 2021-03-15 18:13:36 -04:00
Gary Russell
d9ade78aab Revert "Capture Test Results in PR Workflow"
This reverts commit c29395e722.
2021-03-15 17:27:47 -04:00
Gary Russell
c29395e722 Capture Test Results in PR Workflow 2021-03-15 17:20:27 -04:00
Artem Bilan
6c7ac67588 Use management tag for RabbitMQ image on GH actions (#1283)
* Use management tag for RabbitMQ image on GH actions

* * Add RabbitMQ management ports mapping for service image in the GH actions
2020-12-08 17:21:27 -05:00
Artem Bilan
4b69594237 Add GH Actions integration
* Remove `.travis.yml` since we rely now on GH Actions for PR checks
* Remove all the Travis mentioning when we couldn't pass build because of memory
* Fix `Arnaud Cogoluègnes` name in the `@author` list
2020-12-07 15:52:54 -05:00