17 lines
870 B
Plaintext
17 lines
870 B
Plaintext
= Contributing
|
|
|
|
Before submitting a pull request, please make sure that:
|
|
|
|
1. You've rebased your changes on top of the current `main` branch
|
|
2. If you created a new top level directory: You've included the new directory in `settings.gradle`
|
|
3. You've run `./gradlew updateInfrastructure`
|
|
4. You've run `./gradlew :<name of the group>:<name of the smoke test>:build`
|
|
|
|
== Docker Compose tips
|
|
|
|
If your smoke test uses Docker Compose here are few tips:
|
|
|
|
* Wrap your port values in single quotes (`'8080'`)
|
|
* Do not specify hardcoded port mappings in `docker-compose.yml` - use `'8080'` rather than `'8080':'8080'`
|
|
* Configure your sample app to use the dynamic host (`YOUR_SVC_HOST`) and port (`YOUR_SVC_PORT`) property (see an https://github.com/spring-projects/spring-aot-smoke-tests/blob/main/data/data-jdbc-postgresql/src/main/resources/application.properties[example])
|