From 0d7727a7d480ca71ea2d7e19c8a2503390d0d75c Mon Sep 17 00:00:00 2001 From: Joe Grandja Date: Thu, 22 Jul 2021 04:56:27 -0400 Subject: [PATCH] Make Settings implementations immutable Closes gh-366 --- ...OAuth2AuthorizationEndpointConfigurer.java | 8 +- .../OAuth2AuthorizationServerConfigurer.java | 22 +- .../authorization/OAuth2ConfigurerUtils.java | 2 +- .../OAuth2TokenEndpointConfigurer.java | 4 +- .../authentication/JwtUtils.java | 2 +- ...thorizationCodeAuthenticationProvider.java | 4 +- ...tionCodeRequestAuthenticationProvider.java | 4 +- .../OAuth2ClientAuthenticationProvider.java | 2 +- ...ientCredentialsAuthenticationProvider.java | 2 +- ...th2RefreshTokenAuthenticationProvider.java | 6 +- .../JdbcRegisteredClientRepository.java | 12 +- .../client/RegisteredClient.java | 42 ++-- .../config/AbstractSettings.java | 137 ++++++++++ .../authorization/config/ClientSettings.java | 112 +++++---- .../config/ProviderSettings.java | 235 ++++++++++-------- .../server/authorization/config/Settings.java | 104 -------- .../authorization/config/TokenSettings.java | 171 +++++++------ ...entRegistrationAuthenticationProvider.java | 18 +- ...dcProviderConfigurationEndpointFilter.java | 8 +- ...orizationServerMetadataEndpointFilter.java | 12 +- .../server/authorization/JwkSetTests.java | 4 +- .../OAuth2AuthorizationCodeGrantTests.java | 16 +- ...Auth2AuthorizationServerMetadataTests.java | 2 +- .../OAuth2TokenIntrospectionTests.java | 6 +- .../OAuth2TokenRevocationTests.java | 4 +- .../server/authorization/OidcTests.java | 6 +- ...zationCodeAuthenticationProviderTests.java | 7 +- ...odeRequestAuthenticationProviderTests.java | 9 +- ...uth2ClientAuthenticationProviderTests.java | 3 +- ...freshTokenAuthenticationProviderTests.java | 3 +- .../JdbcRegisteredClientRepositoryTests.java | 8 +- .../client/RegisteredClientTests.java | 4 +- .../client/TestRegisteredClients.java | 3 +- .../config/ClientSettingsTests.java | 50 ++-- .../config/ProviderSettingsTests.java | 73 +++--- .../authorization/config/SettingsTests.java | 78 ------ .../config/TokenSettingsTests.java | 81 +++--- ...gistrationAuthenticationProviderTests.java | 8 +- ...viderConfigurationEndpointFilterTests.java | 23 +- ...tionServerMetadataEndpointFilterTests.java | 14 +- .../config/AuthorizationServerConfig.java | 5 +- .../config/AuthorizationServerConfig.java | 5 +- 42 files changed, 674 insertions(+), 645 deletions(-) create mode 100644 oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/config/AbstractSettings.java delete mode 100644 oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/config/Settings.java delete mode 100644 oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/config/SettingsTests.java diff --git a/oauth2-authorization-server/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/authorization/OAuth2AuthorizationEndpointConfigurer.java b/oauth2-authorization-server/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/authorization/OAuth2AuthorizationEndpointConfigurer.java index 2dff06b6..cde3c8ae 100644 --- a/oauth2-authorization-server/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/authorization/OAuth2AuthorizationEndpointConfigurer.java +++ b/oauth2-authorization-server/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/authorization/OAuth2AuthorizationEndpointConfigurer.java @@ -130,7 +130,7 @@ public final class OAuth2AuthorizationEndpointConfigurer extends AbstractOAuth2C * *