From 63c248440c20c4bdac826a50ab1fdd3c8523cabd Mon Sep 17 00:00:00 2001 From: Joe Grandja Date: Thu, 21 Oct 2021 18:21:01 -0400 Subject: [PATCH] Fix PKCE tests in OAuth2ClientAuthenticationProviderTests --- .../OAuth2ClientAuthenticationProviderTests.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2ClientAuthenticationProviderTests.java b/oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2ClientAuthenticationProviderTests.java index 188961f6..3b49f786 100644 --- a/oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2ClientAuthenticationProviderTests.java +++ b/oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2ClientAuthenticationProviderTests.java @@ -184,7 +184,7 @@ public class OAuth2ClientAuthenticationProviderTests { @Test public void authenticateWhenPkceAndInvalidCodeThenThrowOAuth2AuthenticationException() { - RegisteredClient registeredClient = TestRegisteredClients.registeredClient().build(); + RegisteredClient registeredClient = TestRegisteredClients.registeredPublicClient().build(); when(this.registeredClientRepository.findByClientId(eq(registeredClient.getClientId()))) .thenReturn(registeredClient); @@ -209,7 +209,7 @@ public class OAuth2ClientAuthenticationProviderTests { @Test public void authenticateWhenPkceAndRequireProofKeyAndMissingCodeChallengeThenThrowOAuth2AuthenticationException() { - RegisteredClient registeredClient = TestRegisteredClients.registeredClient() + RegisteredClient registeredClient = TestRegisteredClients.registeredPublicClient() .clientSettings(ClientSettings.builder().requireProofKey(true).build()) .build(); when(this.registeredClientRepository.findByClientId(eq(registeredClient.getClientId()))) @@ -235,7 +235,7 @@ public class OAuth2ClientAuthenticationProviderTests { @Test public void authenticateWhenPkceAndMissingCodeVerifierThenThrowOAuth2AuthenticationException() { - RegisteredClient registeredClient = TestRegisteredClients.registeredClient().build(); + RegisteredClient registeredClient = TestRegisteredClients.registeredPublicClient().build(); when(this.registeredClientRepository.findByClientId(eq(registeredClient.getClientId()))) .thenReturn(registeredClient); @@ -260,7 +260,7 @@ public class OAuth2ClientAuthenticationProviderTests { @Test public void authenticateWhenPkceAndPlainMethodAndInvalidCodeVerifierThenThrowOAuth2AuthenticationException() { - RegisteredClient registeredClient = TestRegisteredClients.registeredClient().build(); + RegisteredClient registeredClient = TestRegisteredClients.registeredPublicClient().build(); when(this.registeredClientRepository.findByClientId(eq(registeredClient.getClientId()))) .thenReturn(registeredClient); @@ -284,7 +284,7 @@ public class OAuth2ClientAuthenticationProviderTests { @Test public void authenticateWhenPkceAndS256MethodAndInvalidCodeVerifierThenThrowOAuth2AuthenticationException() { - RegisteredClient registeredClient = TestRegisteredClients.registeredClient().build(); + RegisteredClient registeredClient = TestRegisteredClients.registeredPublicClient().build(); when(this.registeredClientRepository.findByClientId(eq(registeredClient.getClientId()))) .thenReturn(registeredClient);