From 7f294abfbbc59db5a7319aa3b69f62cf776ea7bc Mon Sep 17 00:00:00 2001 From: Joe Grandja Date: Wed, 28 Jul 2021 06:07:52 -0400 Subject: [PATCH] Polish gh-376 --- ...Auth2AuthorizationCodeRequestAuthenticationProvider.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2AuthorizationCodeRequestAuthenticationProvider.java b/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2AuthorizationCodeRequestAuthenticationProvider.java index 8878f6eb..49ead129 100644 --- a/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2AuthorizationCodeRequestAuthenticationProvider.java +++ b/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2AuthorizationCodeRequestAuthenticationProvider.java @@ -232,7 +232,7 @@ public final class OAuth2AuthorizationCodeRequestAuthenticationProvider implemen .build(); } - OAuth2AuthorizationCode authorizationCode = createAuthorizationCode(); + OAuth2AuthorizationCode authorizationCode = generateAuthorizationCode(); OAuth2Authorization authorization = authorizationBuilder(registeredClient, principal, authorizationRequest) .token(authorizationCode) .attribute(OAuth2Authorization.AUTHORIZED_SCOPE_ATTRIBUTE_NAME, authorizationRequest.getScopes()) @@ -268,7 +268,7 @@ public final class OAuth2AuthorizationCodeRequestAuthenticationProvider implemen DEFAULT_AUTHENTICATION_VALIDATOR_RESOLVER.apply(parameterName); } - private OAuth2AuthorizationCode createAuthorizationCode() { + private OAuth2AuthorizationCode generateAuthorizationCode() { Instant issuedAt = Instant.now(); Instant expiresAt = issuedAt.plus(5, ChronoUnit.MINUTES); // TODO Allow configuration for authorization code time-to-live return new OAuth2AuthorizationCode(this.authorizationCodeGenerator.get(), issuedAt, expiresAt); @@ -345,7 +345,7 @@ public final class OAuth2AuthorizationCodeRequestAuthenticationProvider implemen this.authorizationConsentService.save(authorizationConsent); } - OAuth2AuthorizationCode authorizationCode = createAuthorizationCode(); + OAuth2AuthorizationCode authorizationCode = generateAuthorizationCode(); OAuth2Authorization updatedAuthorization = OAuth2Authorization.from(authorization) .token(authorizationCode)