From ee94ef1fdc3e314159ecc9e57c3f97e5f043f756 Mon Sep 17 00:00:00 2001 From: Marten Deinum Date: Wed, 3 Sep 2014 14:41:17 +0200 Subject: [PATCH] Introduce support package --- .../item/excel/{ => support}/AbstractExcelItemReader.java | 6 +++++- .../batch/item/excel/{ => support}/jxl/JxlItemReader.java | 4 ++-- .../batch/item/excel/{ => support}/jxl/JxlSheet.java | 2 +- .../batch/item/excel/{ => support}/jxl/JxlUtils.java | 2 +- .../batch/item/excel/{ => support}/poi/PoiItemReader.java | 4 ++-- .../batch/item/excel/{ => support}/poi/PoiSheet.java | 2 +- .../excel/{ => support}/AbstractExcelItemReaderTests.java | 5 ++++- .../item/excel/{ => support}/jxl/JxlItemReaderTest.java | 6 +++--- .../batch/item/excel/{ => support}/jxl/JxlUtilsTests.java | 6 +++--- .../item/excel/{ => support}/poi/PoiItemReaderXlsTests.java | 6 +++--- .../excel/{ => support}/poi/PoiItemReaderXlsxTests.java | 6 +++--- 11 files changed, 28 insertions(+), 21 deletions(-) rename spring-batch-excel/src/main/java/org/springframework/batch/item/excel/{ => support}/AbstractExcelItemReader.java (96%) rename spring-batch-excel/src/main/java/org/springframework/batch/item/excel/{ => support}/jxl/JxlItemReader.java (94%) rename spring-batch-excel/src/main/java/org/springframework/batch/item/excel/{ => support}/jxl/JxlSheet.java (96%) rename spring-batch-excel/src/main/java/org/springframework/batch/item/excel/{ => support}/jxl/JxlUtils.java (98%) rename spring-batch-excel/src/main/java/org/springframework/batch/item/excel/{ => support}/poi/PoiItemReader.java (92%) rename spring-batch-excel/src/main/java/org/springframework/batch/item/excel/{ => support}/poi/PoiSheet.java (98%) rename spring-batch-excel/src/test/java/org/springframework/batch/item/excel/{ => support}/AbstractExcelItemReaderTests.java (93%) rename spring-batch-excel/src/test/java/org/springframework/batch/item/excel/{ => support}/jxl/JxlItemReaderTest.java (79%) rename spring-batch-excel/src/test/java/org/springframework/batch/item/excel/{ => support}/jxl/JxlUtilsTests.java (92%) rename spring-batch-excel/src/test/java/org/springframework/batch/item/excel/{ => support}/poi/PoiItemReaderXlsTests.java (82%) rename spring-batch-excel/src/test/java/org/springframework/batch/item/excel/{ => support}/poi/PoiItemReaderXlsxTests.java (83%) diff --git a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/AbstractExcelItemReader.java b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/AbstractExcelItemReader.java similarity index 96% rename from spring-batch-excel/src/main/java/org/springframework/batch/item/excel/AbstractExcelItemReader.java rename to spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/AbstractExcelItemReader.java index caba8fa..a9ec734 100644 --- a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/AbstractExcelItemReader.java +++ b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/AbstractExcelItemReader.java @@ -13,10 +13,14 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.batch.item.excel; +package org.springframework.batch.item.excel.support; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import org.springframework.batch.item.excel.ExcelFileParseException; +import org.springframework.batch.item.excel.RowCallbackHandler; +import org.springframework.batch.item.excel.RowMapper; +import org.springframework.batch.item.excel.Sheet; import org.springframework.batch.item.file.ResourceAwareItemReaderItemStream; import org.springframework.batch.item.support.AbstractItemCountingItemStreamItemReader; import org.springframework.beans.factory.InitializingBean; diff --git a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/jxl/JxlItemReader.java b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/jxl/JxlItemReader.java similarity index 94% rename from spring-batch-excel/src/main/java/org/springframework/batch/item/excel/jxl/JxlItemReader.java rename to spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/jxl/JxlItemReader.java index fc13409..4301ad4 100644 --- a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/jxl/JxlItemReader.java +++ b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/jxl/JxlItemReader.java @@ -15,11 +15,11 @@ * limitations under the License. */ -package org.springframework.batch.item.excel.jxl; +package org.springframework.batch.item.excel.support.jxl; import jxl.Workbook; import jxl.read.biff.WorkbookParser; -import org.springframework.batch.item.excel.AbstractExcelItemReader; +import org.springframework.batch.item.excel.support.AbstractExcelItemReader; import org.springframework.batch.item.excel.Sheet; import org.springframework.core.io.Resource; import org.springframework.util.ClassUtils; diff --git a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/jxl/JxlSheet.java b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/jxl/JxlSheet.java similarity index 96% rename from spring-batch-excel/src/main/java/org/springframework/batch/item/excel/jxl/JxlSheet.java rename to spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/jxl/JxlSheet.java index 1d32e83..6c2d86d 100644 --- a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/jxl/JxlSheet.java +++ b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/jxl/JxlSheet.java @@ -15,7 +15,7 @@ * limitations under the License. */ -package org.springframework.batch.item.excel.jxl; +package org.springframework.batch.item.excel.support.jxl; import jxl.Cell; import org.springframework.batch.item.excel.Sheet; diff --git a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/jxl/JxlUtils.java b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/jxl/JxlUtils.java similarity index 98% rename from spring-batch-excel/src/main/java/org/springframework/batch/item/excel/jxl/JxlUtils.java rename to spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/jxl/JxlUtils.java index 3009f5e..a0d583a 100644 --- a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/jxl/JxlUtils.java +++ b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/jxl/JxlUtils.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package org.springframework.batch.item.excel.jxl; +package org.springframework.batch.item.excel.support.jxl; import jxl.Cell; import jxl.Workbook; diff --git a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/poi/PoiItemReader.java b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/poi/PoiItemReader.java similarity index 92% rename from spring-batch-excel/src/main/java/org/springframework/batch/item/excel/poi/PoiItemReader.java rename to spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/poi/PoiItemReader.java index d51aac7..35310ac 100644 --- a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/poi/PoiItemReader.java +++ b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/poi/PoiItemReader.java @@ -14,12 +14,12 @@ * limitations under the License. */ -package org.springframework.batch.item.excel.poi; +package org.springframework.batch.item.excel.support.poi; import org.apache.poi.ss.usermodel.Row; import org.apache.poi.ss.usermodel.Workbook; import org.apache.poi.ss.usermodel.WorkbookFactory; -import org.springframework.batch.item.excel.AbstractExcelItemReader; +import org.springframework.batch.item.excel.support.AbstractExcelItemReader; import org.springframework.batch.item.excel.Sheet; import org.springframework.core.io.Resource; diff --git a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/poi/PoiSheet.java b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/poi/PoiSheet.java similarity index 98% rename from spring-batch-excel/src/main/java/org/springframework/batch/item/excel/poi/PoiSheet.java rename to spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/poi/PoiSheet.java index 423f3e0..82af9b3 100644 --- a/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/poi/PoiSheet.java +++ b/spring-batch-excel/src/main/java/org/springframework/batch/item/excel/support/poi/PoiSheet.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package org.springframework.batch.item.excel.poi; +package org.springframework.batch.item.excel.support.poi; import org.apache.poi.ss.usermodel.Cell; import org.apache.poi.ss.usermodel.FormulaEvaluator; diff --git a/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/AbstractExcelItemReaderTests.java b/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/AbstractExcelItemReaderTests.java similarity index 93% rename from spring-batch-excel/src/test/java/org/springframework/batch/item/excel/AbstractExcelItemReaderTests.java rename to spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/AbstractExcelItemReaderTests.java index 21628f5..181ff5f 100644 --- a/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/AbstractExcelItemReaderTests.java +++ b/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/AbstractExcelItemReaderTests.java @@ -13,7 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.batch.item.excel; +package org.springframework.batch.item.excel.support; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -21,7 +21,10 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; import org.springframework.batch.item.ExecutionContext; +import org.springframework.batch.item.excel.RowCallbackHandler; +import org.springframework.batch.item.excel.Sheet; import org.springframework.batch.item.excel.mapping.PassThroughRowMapper; +import org.springframework.batch.item.excel.support.AbstractExcelItemReader; import org.springframework.core.io.ClassPathResource; import org.springframework.test.util.ReflectionTestUtils; import org.springframework.util.StringUtils; diff --git a/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/jxl/JxlItemReaderTest.java b/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/jxl/JxlItemReaderTest.java similarity index 79% rename from spring-batch-excel/src/test/java/org/springframework/batch/item/excel/jxl/JxlItemReaderTest.java rename to spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/jxl/JxlItemReaderTest.java index d701b8c..9ae32ed 100644 --- a/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/jxl/JxlItemReaderTest.java +++ b/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/jxl/JxlItemReaderTest.java @@ -14,10 +14,10 @@ * limitations under the License. */ -package org.springframework.batch.item.excel.jxl; +package org.springframework.batch.item.excel.support.jxl; -import org.springframework.batch.item.excel.AbstractExcelItemReader; -import org.springframework.batch.item.excel.AbstractExcelItemReaderTests; +import org.springframework.batch.item.excel.support.AbstractExcelItemReader; +import org.springframework.batch.item.excel.support.AbstractExcelItemReaderTests; /** * Test diff --git a/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/jxl/JxlUtilsTests.java b/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/jxl/JxlUtilsTests.java similarity index 92% rename from spring-batch-excel/src/test/java/org/springframework/batch/item/excel/jxl/JxlUtilsTests.java rename to spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/jxl/JxlUtilsTests.java index b76e78b..3550267 100644 --- a/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/jxl/JxlUtilsTests.java +++ b/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/jxl/JxlUtilsTests.java @@ -13,7 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.batch.item.excel.jxl; +package org.springframework.batch.item.excel.support.jxl; import jxl.Cell; import jxl.Workbook; @@ -23,7 +23,7 @@ import org.junit.Test; import org.mockito.Mockito; /** - * Tests for {@link org.springframework.batch.item.excel.jxl.JxlUtils}. + * Tests for {@link org.springframework.batch.item.excel.support.jxl.JxlUtils}. * * @author Marten Deinum * @@ -46,7 +46,7 @@ public class JxlUtilsTests { } /** - * Test the {@link org.springframework.batch.item.excel.jxl.JxlUtils#isEmpty( jxl.Cell)} method. + * Test the {@link org.springframework.batch.item.excel.support.jxl.JxlUtils#isEmpty( jxl.Cell)} method. */ @Test public void checkIfCellsAreEmpty() { diff --git a/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/poi/PoiItemReaderXlsTests.java b/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/poi/PoiItemReaderXlsTests.java similarity index 82% rename from spring-batch-excel/src/test/java/org/springframework/batch/item/excel/poi/PoiItemReaderXlsTests.java rename to spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/poi/PoiItemReaderXlsTests.java index e395802..df27a5a 100644 --- a/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/poi/PoiItemReaderXlsTests.java +++ b/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/poi/PoiItemReaderXlsTests.java @@ -13,12 +13,12 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.batch.item.excel.poi; +package org.springframework.batch.item.excel.support.poi; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; -import org.springframework.batch.item.excel.AbstractExcelItemReader; -import org.springframework.batch.item.excel.AbstractExcelItemReaderTests; +import org.springframework.batch.item.excel.support.AbstractExcelItemReader; +import org.springframework.batch.item.excel.support.AbstractExcelItemReaderTests; public class PoiItemReaderXlsTests extends AbstractExcelItemReaderTests { diff --git a/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/poi/PoiItemReaderXlsxTests.java b/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/poi/PoiItemReaderXlsxTests.java similarity index 83% rename from spring-batch-excel/src/test/java/org/springframework/batch/item/excel/poi/PoiItemReaderXlsxTests.java rename to spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/poi/PoiItemReaderXlsxTests.java index 563ec55..7a90385 100644 --- a/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/poi/PoiItemReaderXlsxTests.java +++ b/spring-batch-excel/src/test/java/org/springframework/batch/item/excel/support/poi/PoiItemReaderXlsxTests.java @@ -13,10 +13,10 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.batch.item.excel.poi; +package org.springframework.batch.item.excel.support.poi; -import org.springframework.batch.item.excel.AbstractExcelItemReader; -import org.springframework.batch.item.excel.AbstractExcelItemReaderTests; +import org.springframework.batch.item.excel.support.AbstractExcelItemReader; +import org.springframework.batch.item.excel.support.AbstractExcelItemReaderTests; import org.springframework.core.io.ClassPathResource; public class PoiItemReaderXlsxTests extends AbstractExcelItemReaderTests {