Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Test cases for BATCH-1256 and BATCH-1259

Browse Source
This commit is contained in:
dhgarrette
2009-05-31 14:54:46 +00:00
parent 955045ed97
commit 001893bb8c
3 changed files with 91 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

89
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantStepFactoryBeanRollbackTests.java
View File

@@ -285,12 +285,97 @@ public class FaultTolerantStepFactoryBeanRollbackTests {
// Two multi-item chunks rolled back. When the item was encountered on
// its own it can proceed
assertEquals(2, stepExecution.getRollbackCount());
}
@Test
public void testSkipInProcessor() throws Exception {
processor.setFailures("4");
factory.setCommitInterval(30);
Step step = (Step) factory.getObject();
step.execute(stepExecution);
assertEquals(BatchStatus.COMPLETED, stepExecution.getStatus());
assertEquals("[1, 2, 3, 4, 1, 2, 3, 5]", processor.getProcessed().toString());
assertEquals("[1, 2, 3, 5]", processor.getCommitted().toString());
assertEquals("[1, 2, 3, 5]", writer.getWritten().toString());
assertEquals("[1, 2, 3, 5]", writer.getCommitted().toString());
}
@Test
public void testMultipleSkipsInProcessor() throws Exception {
processor.setFailures("2", "4");
factory.setCommitInterval(30);
Step step = (Step) factory.getObject();
step.execute(stepExecution);
assertEquals(BatchStatus.COMPLETED, stepExecution.getStatus());
// TODO: Fix this with BATCH-1259?
assertEquals("[1, 2, 1, 3, 4, 1, 3, 5]", processor.getProcessed().toString());
assertEquals("[1, 3, 5]", processor.getCommitted().toString());
assertEquals("[1, 3, 5]", writer.getWritten().toString());
assertEquals("[1, 3, 5]", writer.getCommitted().toString());
}
@Test
public void testFilterInProcessor() throws Exception {
processor.setFailures("4");
processor.setFilter(true);
factory.setCommitInterval(30);
Step step = (Step) factory.getObject();
step.execute(stepExecution);
assertEquals(BatchStatus.COMPLETED, stepExecution.getStatus());
assertEquals("[1, 2, 3, 4, 5]", processor.getProcessed().toString());
assertEquals("[1, 2, 3, 5]", processor.getCommitted().toString());
assertEquals("[1, 2, 3, 5]", writer.getWritten().toString());
assertEquals("[1, 2, 3, 5]", writer.getCommitted().toString());
}
@Test
public void testSkipInWriter() throws Exception {
writer.setFailures("4");
factory.setCommitInterval(30);
Step step = (Step) factory.getObject();
step.execute(stepExecution);
assertEquals(BatchStatus.COMPLETED, stepExecution.getStatus());
// TODO: Fix this with BATCH-1256
assertEquals("[1, 2, 3, 4, 5, 1, 2, 3, 4, 5, 2, 3, 4, 5, 3, 4, 5, 4, 5, 5]", processor.getProcessed()
.toString());
assertEquals("[1, 2, 3, 4, 5, 2, 3, 4, 5, 3, 4, 5, 5]", processor.getCommitted().toString());
assertEquals("[1, 2, 3, 4, 1, 2, 3, 4, 5]", writer.getWritten().toString());
assertEquals("[1, 2, 3, 5]", writer.getCommitted().toString());
}
@Test
public void testMultipleSkipsInWriter() throws Exception {
writer.setFailures("2", "4");
factory.setCommitInterval(30);
Step step = (Step) factory.getObject();
step.execute(stepExecution);
assertEquals(BatchStatus.COMPLETED, stepExecution.getStatus());
// TODO: Fix this with BATCH-1256
assertEquals("[1, 2, 3, 4, 5, 1, 2, 3, 4, 5, 2, 3, 4, 5, 3, 4, 5, 4, 5, 5]", processor.getProcessed()
.toString());
assertEquals("[1, 2, 3, 4, 5, 3, 4, 5, 5]", processor.getCommitted().toString());
assertEquals("[1, 2, 1, 2, 3, 4, 5]", writer.getWritten().toString());
assertEquals("[1, 3, 5]", writer.getCommitted().toString());
}
@SuppressWarnings("unchecked")
private Collection<Class<? extends Throwable>> getExceptionList(Class<? extends Throwable> args) {
return Arrays.<Class<? extends Throwable>> asList(args);
private Collection<Class<? extends Throwable>> getExceptionList(Class<? extends Throwable> arg) {
return Arrays.<Class<? extends Throwable>> asList(arg);
}
}

6
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/SkipProcessorStub.java
View File

@@ -54,18 +54,18 @@ public class SkipProcessorStub<T> extends ExceptionThrowingItemHandlerStub<T> im
public T process(T item) throws Exception {
processed.add(item);
committed.add(item);
try {
checkFailure(item);
}
catch (Exception e) {
if(filter){
if (filter) {
return null;
}
else{
else {
throw e;
}
}
committed.add(item);
return item;
}
}

2
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/SkipWriterStub.java
View File

@@ -48,8 +48,8 @@ public class SkipWriterStub<T> extends ExceptionThrowingItemHandlerStub<T> imple
public void write(List<? extends T> items) throws Exception {
for (T item : items) {
written.add(item);
committed.add(item);
checkFailure(item);
committed.add(item);
}
}
}