From 03b8880cfca549f94ec541f4c83d24719a65feb5 Mon Sep 17 00:00:00 2001 From: dsyer Date: Thu, 4 Mar 2010 14:57:55 +0000 Subject: [PATCH] RESOLVED - issue BATCH-1526: Memory leak in web deployments because ThreadLocal is not nulled out in ChunkMonitor --- .../springframework/batch/core/step/item/ChunkMonitor.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkMonitor.java b/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkMonitor.java index 887b6e3cd..97b669f38 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkMonitor.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkMonitor.java @@ -54,11 +54,6 @@ class ChunkMonitor implements ItemStream { private CompositeItemStream stream = new CompositeItemStream(); private ThreadLocal holder = new ThreadLocal(); - { - // For testing purposes, make an instance of the offset data - // available: - holder.set(new ChunkMonitorData(0, 0)); - } private ItemReader reader; @@ -99,7 +94,7 @@ class ChunkMonitor implements ItemStream { } public void close() throws ItemStreamException { - holder.set(new ChunkMonitorData(0,0)); + holder.set(null); if (streamsRegistered) { stream.close(); }