Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add final keyword for mutex

Browse Source
This commit is contained in:
dsyer
2008-12-02 18:51:22 +00:00
parent 173e9a259c
commit 0419b2139c
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
spring-batch-core/src/main/java/org/springframework/batch/core/scope/StepScope.java
View File

@@ -76,7 +76,7 @@ public class StepScope implements Scope, BeanFactoryPostProcessor, Ordered {
private int order = Ordered.LOWEST_PRECEDENCE; private int order = Ordered.LOWEST_PRECEDENCE;
private Object mutex = new Object(); private final Object mutex = new Object();
/** /**
* @param order the order value to set priority of callback execution for * @param order the order value to set priority of callback execution for
@@ -115,11 +115,6 @@ public class StepScope implements Scope, BeanFactoryPostProcessor, Ordered {
logger.debug(String.format("Creating object in scope=%s, name=%s", this.name, name)); logger.debug(String.format("Creating object in scope=%s, name=%s", this.name, name));
/**
* Here is where we need to inject some context (a root
* object for expressions). The ObjectFactory could take a
* parameter?
*/
scopedObject = objectFactory.getObject(); scopedObject = objectFactory.getObject();
context.setAttribute(name, scopedObject); context.setAttribute(name, scopedObject);
@@ -211,7 +206,7 @@ public class StepScope implements Scope, BeanFactoryPostProcessor, Ordered {
public void setName(String name) { public void setName(String name) {
this.name = name; this.name = name;
} }
/** /**
* Wrap a target bean definition in a proxy that defers initialization until * Wrap a target bean definition in a proxy that defers initialization until
* after the {@link StepContext} is available. Amounts to adding * after the {@link StepContext} is available. Amounts to adding
@@ -234,8 +229,8 @@ public class StepScope implements Scope, BeanFactoryPostProcessor, Ordered {
// TODO: detect presence of Spring 3.0 and use ScopedPoxyUtils instead // TODO: detect presence of Spring 3.0 and use ScopedPoxyUtils instead
// Create the scoped proxy... // Create the scoped proxy...
BeanDefinitionHolder proxyHolder = PlaceholderProxyFactoryBean.createScopedProxy(new BeanDefinitionHolder(definition, beanName), registry, BeanDefinitionHolder proxyHolder = PlaceholderProxyFactoryBean.createScopedProxy(new BeanDefinitionHolder(
proxyTargetClass); definition, beanName), registry, proxyTargetClass);
// ...and register it under the original target name // ...and register it under the original target name
registry.registerBeanDefinition(beanName, proxyHolder.getBeanDefinition()); registry.registerBeanDefinition(beanName, proxyHolder.getBeanDefinition());