From 0ae4fa24618d5d8b9e04ea7d9cf420808f5eba03 Mon Sep 17 00:00:00 2001 From: robokaso Date: Tue, 16 Sep 2008 11:33:24 +0000 Subject: [PATCH] OPEN - BATCH-803: Add non-buffering ChunkOrientedTasklet (or option in existing one) plus flag for factory bean moved read counting inside the read loop and removed unused incrementReadCount(int) method --- .../org/springframework/batch/core/StepContribution.java | 7 ------- .../batch/core/step/item/ChunkOrientedTasklet.java | 3 +-- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/StepContribution.java b/spring-batch-core/src/main/java/org/springframework/batch/core/StepContribution.java index bb6cacf86..483e51e3b 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/StepContribution.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/StepContribution.java @@ -59,13 +59,6 @@ public class StepContribution { readCount++; } - /** - * Increment the counter for the number of items read. - */ - public void incrementReadCount(int count) { - readCount += count; - } - /** * Increment the counter for the number of items written. */ diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkOrientedTasklet.java b/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkOrientedTasklet.java index 0b2f22890..cba070236 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkOrientedTasklet.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkOrientedTasklet.java @@ -135,6 +135,7 @@ public class ChunkOrientedTasklet implements Tasklet { return ExitStatus.FINISHED; } inputs.add(item); + contribution.incrementReadCount(); return ExitStatus.CONTINUABLE; } }); @@ -143,8 +144,6 @@ public class ChunkOrientedTasklet implements Tasklet { if (inputs.isEmpty()) { return result; } - - contribution.incrementReadCount(inputs.size()); storeInputs(attributes, inputs);