From 12926b46c9686020e1ee90f6583df7b13700b45a Mon Sep 17 00:00:00 2001 From: Mahmoud Ben Hassine Date: Thu, 3 Dec 2020 15:58:48 +0100 Subject: [PATCH] Remove ignored test Based on the commit message of df1783a7, this test has no added value. --- .../ConcurrentTransactionAwareProxyTests.java | 21 ++----------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/support/transaction/ConcurrentTransactionAwareProxyTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/support/transaction/ConcurrentTransactionAwareProxyTests.java index 9ebc41cb8..012a9f635 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/support/transaction/ConcurrentTransactionAwareProxyTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/support/transaction/ConcurrentTransactionAwareProxyTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2006-2009 the original author or authors. + * Copyright 2006-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -47,6 +47,7 @@ import org.springframework.util.Assert; /** * @author Dave Syer + * @author Mahmoud Ben Hassine * */ public class ConcurrentTransactionAwareProxyTests { @@ -92,24 +93,6 @@ public class ConcurrentTransactionAwareProxyTests { testList(list, false); } - @Ignore("This fails too often and is a false negative") - @Test - public void testConcurrentTransactionalList() throws Exception { - List list = TransactionAwareProxyFactory.createTransactionalList(); - try { - testList(list, true); - fail("Expected ExecutionException or AssertionError (but don't panic if it didn't happen: it probably just means we got lucky for a change)"); - } - catch (ExecutionException e) { - String message = e.getCause().getMessage(); - assertTrue("Wrong message: " + message, message.startsWith("Lost update")); - } - catch (AssertionError e) { - String message = e.getMessage(); - assertTrue("Wrong message: " + message, message.startsWith("Wrong number of results")); - } - } - @Test public void testConcurrentTransactionalAppendOnlyMap() throws Exception { Map> map = TransactionAwareProxyFactory.createAppendOnlyTransactionalMap();