From 134f81655ccb8f8f08c2a8b4a0b1fb81631a8920 Mon Sep 17 00:00:00 2001 From: trisberg Date: Thu, 7 Aug 2008 01:24:50 +0000 Subject: [PATCH] BATCH-710: added some @Test and removed @Transactional for the ItemReader tests --- .../HibernateCursorItemReaderIntegrationTests.java | 2 ++ .../HibernateCursorItemReaderStatefulIntegrationTests.java | 2 ++ ...ibernateCursorProjectionItemReaderIntegrationTests.java | 7 ++----- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorItemReaderIntegrationTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorItemReaderIntegrationTests.java index b5a6f8ece..8539cc526 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorItemReaderIntegrationTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorItemReaderIntegrationTests.java @@ -2,6 +2,7 @@ package org.springframework.batch.item.database; import static org.junit.Assert.*; import org.junit.runner.RunWith; +import org.junit.Test; import org.hibernate.SessionFactory; import org.hibernate.StatelessSession; @@ -53,6 +54,7 @@ public class HibernateCursorItemReaderIntegrationTests extends AbstractDataSourc * {@link HibernateCursorItemReader#setUseStatelessSession(boolean)} can be * called only in uninitialized state. */ + @Test public void testSetUseStatelessSession() { HibernateCursorItemReader inputSource = (HibernateCursorItemReader)reader; diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorItemReaderStatefulIntegrationTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorItemReaderStatefulIntegrationTests.java index 8b0657230..ebe4a3e88 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorItemReaderStatefulIntegrationTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorItemReaderStatefulIntegrationTests.java @@ -9,6 +9,7 @@ import org.springframework.batch.item.sample.Foo; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; import org.springframework.test.context.ContextConfiguration; import org.junit.runner.RunWith; +import org.junit.Test; /** * Tests for {@link HibernateCursorItemReader} using standard hibernate {@link Session}. @@ -24,6 +25,7 @@ public class HibernateCursorItemReaderStatefulIntegrationTests extends Hibernate } //Ensure close is called on the stateful session correctly. + @Test public void testStatfulClose(){ SessionFactory sessionFactory = createMock(SessionFactory.class); diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorProjectionItemReaderIntegrationTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorProjectionItemReaderIntegrationTests.java index 7249c2999..50df4c149 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorProjectionItemReaderIntegrationTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateCursorProjectionItemReaderIntegrationTests.java @@ -32,15 +32,12 @@ public class HibernateCursorProjectionItemReaderIntegrationTests { protected ItemReader reader; - protected ExecutionContext executionContext; - @Autowired protected DataSource dataSource; @Before - public void onSetUpInTransaction() throws Exception { + public void onSetUp() throws Exception { reader = createItemReader(); - executionContext = new ExecutionContext(); } @@ -63,7 +60,7 @@ public class HibernateCursorProjectionItemReaderIntegrationTests { return inputSource; } - @Transactional @Test + @Test public void testNormalProcessing() throws Exception { ((InitializingBean) reader).afterPropertiesSet(); ((ItemStream) reader).open(new ExecutionContext());