From 21f23e05d1076741df1245d25ece05b87e2e6fbf Mon Sep 17 00:00:00 2001 From: lucasward Date: Wed, 23 Jan 2008 23:17:51 +0000 Subject: [PATCH] BATCH-311:Added factory for JobInstanceProperties. --- .../batch/core/domain/JobInstanceProperties.java | 4 ++++ .../batch/core/domain/JobInstancePropertiesTests.java | 9 +++++++++ 2 files changed, 13 insertions(+) diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/domain/JobInstanceProperties.java b/spring-batch-core/src/main/java/org/springframework/batch/core/domain/JobInstanceProperties.java index ea54c107d..0607fe6bd 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/domain/JobInstanceProperties.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/domain/JobInstanceProperties.java @@ -168,6 +168,10 @@ public class JobInstanceProperties { return tempMap; } + public boolean isEmtpy(){ + return dateMap.isEmpty() && longMap.isEmpty() && stringMap.isEmpty(); + } + public boolean equals(Object obj) { if(obj instanceof JobInstanceProperties == false){ diff --git a/spring-batch-core/src/test/java/org/springframework/batch/core/domain/JobInstancePropertiesTests.java b/spring-batch-core/src/test/java/org/springframework/batch/core/domain/JobInstancePropertiesTests.java index 0531a486b..773098b80 100644 --- a/spring-batch-core/src/test/java/org/springframework/batch/core/domain/JobInstancePropertiesTests.java +++ b/spring-batch-core/src/test/java/org/springframework/batch/core/domain/JobInstancePropertiesTests.java @@ -152,6 +152,15 @@ public class JobInstancePropertiesTests extends TestCase { assertEquals(string1, string2); } + + public void testIsEmpty(){ + + JobInstanceProperties props = new JobInstanceProperties(); + assertTrue(props.isEmtpy()); + + props = new JobInstancePropertiesBuilder().addString("test", "test").toJobParameters(); + assertFalse(props.isEmtpy()); + } // Not sure how to properly test this since there is no order garuntee, commenting out for now. //