From 260a49649c5ef69b872e64f1835d2bc8ece00fb7 Mon Sep 17 00:00:00 2001
From: dhgarrette <dhgarrette@2e8e966d-6415-0410-94b9-dc4e65435d03>
Date: Fri, 13 Mar 2009 07:32:40 +0000
Subject: [PATCH] BATCH-1139: Add requirement that standalone <tasklet/> be
 abstract.  Otherwise users might think that they can use <step tasklet="?"/>
 to refer to it.  They must always use <tasklet parent="?"/>.

---
 .../core/configuration/xml/TopLevelTaskletElementParser.java | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/configuration/xml/TopLevelTaskletElementParser.java b/spring-batch-core/src/main/java/org/springframework/batch/core/configuration/xml/TopLevelTaskletElementParser.java
index 0ac485bff..1ed6b9f8c 100644
--- a/spring-batch-core/src/main/java/org/springframework/batch/core/configuration/xml/TopLevelTaskletElementParser.java
+++ b/spring-batch-core/src/main/java/org/springframework/batch/core/configuration/xml/TopLevelTaskletElementParser.java
@@ -34,6 +34,11 @@ public class TopLevelTaskletElementParser extends AbstractBeanDefinitionParser {
 	@Override
 	protected AbstractBeanDefinition parseInternal(Element element, ParserContext parserContext) {
 
+		if (!Boolean.valueOf(element.getAttribute("abstract"))) {
+			parserContext.getReaderContext().error(
+					"The <tasklet/> element, when not contained with a <step/>, must be abstract", element);
+		}
+
 		return taskletElementParser.parse(element, parserContext);
 
 	}