From 2624601d9ed2f1dc0b466e33ab5ceb4ca1c517f0 Mon Sep 17 00:00:00 2001 From: robokaso Date: Fri, 23 May 2008 15:33:01 +0000 Subject: [PATCH] IN PROGRESS - BATCH-520: Add a Delegating File Reader For Multiple Files added javadoc concerning importance of resource ordering on restart + TODO for improvements --- .../springframework/batch/item/MultiResourceItemReader.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/MultiResourceItemReader.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/MultiResourceItemReader.java index ab30e6956..35d885761 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/MultiResourceItemReader.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/MultiResourceItemReader.java @@ -13,7 +13,11 @@ import org.springframework.util.Assert; * {@link #setResources(Resource[])}, the actual reading is delegated to * {@link #setDelegate(ResourceAwareItemReaderItemStream)}. * - * Reset (rollback) capability is implemented by item buffering. + * Reset (rollback) capability is implemented by item buffering. To restart + * correctly resource ordering needs to be preserved between runs. + * + * TODO more robust restart e.g. sort resources alphabetically and store + * filename instead of resource array index. * * @author Robert Kasanicky */