From 2672e055b8c9718dc1a1912cc4f2f891337ea72c Mon Sep 17 00:00:00 2001 From: robokaso Date: Mon, 26 Jan 2009 15:09:20 +0000 Subject: [PATCH] RESOLVED - BATCH-1015: ItemListenerSupport should implement ItemProcessListener applied patch --- .../core/listener/ItemListenerSupport.java | 94 +++++++++++++------ 1 file changed, 67 insertions(+), 27 deletions(-) diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/listener/ItemListenerSupport.java b/spring-batch-core/src/main/java/org/springframework/batch/core/listener/ItemListenerSupport.java index 91fa5a845..5402580ed 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/listener/ItemListenerSupport.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/listener/ItemListenerSupport.java @@ -17,53 +17,93 @@ package org.springframework.batch.core.listener; import java.util.List; +import org.springframework.batch.core.ItemProcessListener; import org.springframework.batch.core.ItemReadListener; import org.springframework.batch.core.ItemWriteListener; /** - * Basic no-op implementation of both the {@link ItemWriteListener} and - * {@link ItemReadListener} interfaces. Both are implemented, since it is - * very common that both may need to be implemented at once. + * Basic no-op implementation of the {@link ItemReadListener}, + * {@link ItemProcessListener}, and {@link ItemWriteListener} interfaces. All + * are implemented, since it is very common that all may need to be implemented + * at once. * * @author Lucas Ward - * + * */ -public class ItemListenerSupport implements ItemWriteListener, ItemReadListener { +public class ItemListenerSupport implements ItemReadListener, ItemProcessListener, ItemWriteListener { - /* (non-Javadoc) - * @see org.springframework.batch.core.domain.ItemWriteListener#afterWrite() - */ - public void afterWrite(List item) { - } - - /* (non-Javadoc) - * @see org.springframework.batch.core.domain.ItemWriteListener#beforeWrite(java.lang.Object) - */ - public void beforeWrite(List item) { - } - - /* (non-Javadoc) - * @see org.springframework.batch.core.domain.ItemWriteListener#onWriteError(java.lang.Exception, java.lang.Object) - */ - public void onWriteError(Exception ex, List item) { - } - - /* (non-Javadoc) + /* + * (non-Javadoc) + * * @see org.springframework.batch.core.domain.ItemReadListener#afterRead(java.lang.Object) */ - public void afterRead(T item) { + public void afterRead(I item) { } - /* (non-Javadoc) + /* + * (non-Javadoc) + * * @see org.springframework.batch.core.domain.ItemReadListener#beforeRead() */ public void beforeRead() { } - /* (non-Javadoc) + /* + * (non-Javadoc) + * * @see org.springframework.batch.core.domain.ItemReadListener#onReadError(java.lang.Exception) */ public void onReadError(Exception ex) { } + /* + * (non-Javadoc) + * + * @see org.springframework.batch.core.ItemProcessListener#afterProcess(java.lang.Object, + * java.lang.Object) + */ + public void afterProcess(I item, O result) { + } + + /* + * (non-Javadoc) + * + * @see org.springframework.batch.core.ItemProcessListener#beforeProcess(java.lang.Object) + */ + public void beforeProcess(I item) { + } + + /* + * (non-Javadoc) + * + * @see org.springframework.batch.core.ItemProcessListener#onProcessError(java.lang.Object, + * java.lang.Exception) + */ + public void onProcessError(I item, Exception e) { + } + + /* + * (non-Javadoc) + * + * @see org.springframework.batch.core.domain.ItemWriteListener#afterWrite() + */ + public void afterWrite(List item) { + } + + /* + * (non-Javadoc) + * + * @see org.springframework.batch.core.domain.ItemWriteListener#beforeWrite(java.lang.Object) + */ + public void beforeWrite(List item) { + } + + /* + * (non-Javadoc) + * + * @see org.springframework.batch.core.domain.ItemWriteListener#onWriteError(java.lang.Exception, + * java.lang.Object) + */ + public void onWriteError(Exception ex, List item) { + } }