Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - BATCH-774: Split item count into read/write/filter

Browse Source 
removed itemCount from StepContribution
This commit is contained in:
robokaso
2008-09-03 13:39:14 +00:00
parent 9e07cda1b3
commit 27b306566e
5 changed files with 14 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spring-batch-core/src/test/java/org/springframework/batch/core/StepContributionTests.java
View File

@@ -29,17 +29,7 @@ public class StepContributionTests extends TestCase {
/**
* Test method for
* {@link org.springframework.batch.core.StepContribution#incrementItemCount()}.
*/
public void testIncrementTaskCount() {
assertEquals(0, contribution.getItemCount());
contribution.incrementItemCount();
assertEquals(1, contribution.getItemCount());
}
/**
* Test method for
* {@link org.springframework.batch.core.StepContribution#incrementItemCount()}.
* {@link org.springframework.batch.core.StepContribution#incrementFilterCount(int)}.
*/
public void testIncrementFilterCount() {
assertEquals(0, contribution.getFilterCount());

3
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/ChunkOrientedTaskletTests.java
View File

@@ -84,7 +84,7 @@ public class ChunkOrientedTaskletTests {
// expected
}
assertEquals(2, itemReader.count);
assertEquals(2, contribution.getItemCount());
assertEquals(2, contribution.getReadCount());
assertEquals(0, contribution.getFilterCount());
assertEquals("", itemWriter.values);
}
@@ -97,7 +97,6 @@ public class ChunkOrientedTaskletTests {
123L, new JobParameters(), "job"))));
handler.execute(contribution, context);
assertEquals(2, itemReader.count);
assertEquals(2, contribution.getItemCount());
assertEquals(2, contribution.getReadCount());
assertEquals(1, contribution.getFilterCount());
assertEquals(1, contribution.getWriteCount());

4
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/StatefulRetryTaskletTests.java
View File

@@ -135,7 +135,7 @@ public class StatefulRetryTaskletTests {
catch (SkipLimitExceededException e) {
// expected
}
assertEquals(0, contribution.getItemCount());
assertEquals(0, contribution.getReadCount());
assertEquals(2, contribution.getReadSkipCount());
}
@@ -304,7 +304,7 @@ public class StatefulRetryTaskletTests {
// expected
}
assertTrue(attributes.hasAttribute("INPUT_BUFFER_KEY"));
assertEquals(0, contribution.getItemCount());
assertEquals(0, contribution.getReadCount());
assertEquals(2, contribution.getProcessSkipCount());
// Just before the skip at the end we process once more
assertEquals(3, processed.size());