From 2c5c74a4a62ed8b3cadba2652c0c1335900244e8 Mon Sep 17 00:00:00 2001 From: lucasward Date: Tue, 16 Oct 2007 16:41:30 +0000 Subject: [PATCH] BATCH-172 - Added additional error checking to HibernateDao --- .../batch/execution/repository/dao/HibernateJobDao.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/execution/src/main/java/org/springframework/batch/execution/repository/dao/HibernateJobDao.java b/execution/src/main/java/org/springframework/batch/execution/repository/dao/HibernateJobDao.java index 4ea5947e8..4f54c31e1 100644 --- a/execution/src/main/java/org/springframework/batch/execution/repository/dao/HibernateJobDao.java +++ b/execution/src/main/java/org/springframework/batch/execution/repository/dao/HibernateJobDao.java @@ -68,7 +68,7 @@ public class HibernateJobDao extends HibernateDaoSupport implements JobDao { */ public List findJobs(JobIdentifier jobIdentifier) { - final ScheduledJobIdentifier jobRuntimeInformation = (ScheduledJobIdentifier) jobIdentifier; + final JobIdentifier jobRuntimeInformation = jobIdentifier; validateJobIdentifier(jobRuntimeInformation); @@ -201,8 +201,8 @@ public class HibernateJobDao extends HibernateDaoSupport implements JobDao { private void validateJobIdentifier(JobIdentifier jobIdentifier) { Assert.notNull(jobIdentifier, "JobRuntimeInformation cannot be null."); - Assert.notNull(jobIdentifier.getName(), - "JobRuntimeInformation name cannot be null."); + Assert.hasText(jobIdentifier.getName(), + "JobRuntimeInformation name cannot be null or empty."); if (jobIdentifier instanceof ScheduledJobIdentifier) { ScheduledJobIdentifier jobRuntimeInformation = (ScheduledJobIdentifier) jobIdentifier;