From 2f66e56b84e6934dd980feb86b66cb0b15203448 Mon Sep 17 00:00:00 2001 From: dsyer Date: Wed, 13 Jan 2010 09:24:13 +0000 Subject: [PATCH] RESOLVED - issue BATCH-1239: Add email-sending item writer --- .../sample/domain/mail/internal/TestMailErrorHandler.java | 5 ++--- .../springframework/batch/sample/MailJobFunctionalTests.java | 5 +++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/mail/internal/TestMailErrorHandler.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/mail/internal/TestMailErrorHandler.java index c294223dd..f2fbf5fc8 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/mail/internal/TestMailErrorHandler.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/mail/internal/TestMailErrorHandler.java @@ -22,7 +22,6 @@ import javax.mail.MessagingException; import org.springframework.batch.item.mail.MailErrorHandler; import org.springframework.mail.MailMessage; -import org.springframework.mail.SimpleMailMessage; /** * This handler prints out failed messages with their exceptions. It also @@ -36,7 +35,7 @@ import org.springframework.mail.SimpleMailMessage; */ public class TestMailErrorHandler implements MailErrorHandler { - private List failedMessages = new ArrayList(); + private List failedMessages = new ArrayList(); public void handle(MailMessage failedMessage, MessagingException ex) { this.failedMessages.add(failedMessage); @@ -44,7 +43,7 @@ public class TestMailErrorHandler implements MailErrorHandler { System.out.println(ex); } - public List getFailedMessages() { + public List getFailedMessages() { return failedMessages; } diff --git a/spring-batch-samples/src/test/java/org/springframework/batch/sample/MailJobFunctionalTests.java b/spring-batch-samples/src/test/java/org/springframework/batch/sample/MailJobFunctionalTests.java index 7b0c22cf3..53c1465ca 100644 --- a/spring-batch-samples/src/test/java/org/springframework/batch/sample/MailJobFunctionalTests.java +++ b/spring-batch-samples/src/test/java/org/springframework/batch/sample/MailJobFunctionalTests.java @@ -33,6 +33,7 @@ import org.springframework.batch.sample.domain.mail.internal.TestMailSender; import org.springframework.batch.test.JobLauncherTestUtils; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.jdbc.core.simple.SimpleJdbcTemplate; +import org.springframework.mail.MailMessage; import org.springframework.mail.SimpleMailMessage; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; @@ -109,9 +110,9 @@ public class MailJobFunctionalTests { } assertEquals(2, this.errorHandler.getFailedMessages().size()); - Iterator failureItr = this.errorHandler.getFailedMessages().iterator(); + Iterator failureItr = this.errorHandler.getFailedMessages().iterator(); for (Object[] record : new Object[][] { USER2_SKIP, USER4_SKIP }) { - SimpleMailMessage email = failureItr.next(); + SimpleMailMessage email = (SimpleMailMessage) failureItr.next(); assertEquals("Hello " + record[1], email.getText()); } }