From 3c098f6cb8aef0fd91571a2fa62bfe9e5a8448ed Mon Sep 17 00:00:00 2001 From: trisberg Date: Sun, 31 Aug 2008 16:33:50 +0000 Subject: [PATCH] BATCH-799 deprecated DrivingQueryItemReader support in favor of PagingItemReaders --- .../batch/item/database/DrivingQueryItemReader.java | 2 ++ .../batch/item/database/IbatisDrivingQueryItemReader.java | 2 ++ .../org/springframework/batch/item/database/KeyCollector.java | 2 ++ .../batch/item/database/support/IbatisKeyCollector.java | 2 ++ .../item/database/support/MultipleColumnJdbcKeyCollector.java | 2 ++ .../item/database/support/SingleColumnJdbcKeyCollector.java | 2 ++ 6 files changed, 12 insertions(+) diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/DrivingQueryItemReader.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/DrivingQueryItemReader.java index 0a72b064b..d588cdcb9 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/DrivingQueryItemReader.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/DrivingQueryItemReader.java @@ -64,6 +64,8 @@ import org.springframework.util.Assert; * * * @author Lucas Ward + * @deprecated The DrivingQueryItemReader approach is not supported going forward, use a PagingItemReader + * implementation instead. See {@link org.springframework.batch.item.database.AbstractPagingItemReader} */ public class DrivingQueryItemReader implements ItemReader, InitializingBean, ItemStream { diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/IbatisDrivingQueryItemReader.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/IbatisDrivingQueryItemReader.java index 7be93f108..cb3cc3c1b 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/IbatisDrivingQueryItemReader.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/IbatisDrivingQueryItemReader.java @@ -32,6 +32,8 @@ import com.ibatis.sqlmap.client.SqlMapClient; * * @author Lucas Ward * @see IbatisKeyCollector + * @deprecated The DrivingQueryItemReader approach is not supported going forward, use a PagingItemReader + * implementation instead. See {@link org.springframework.batch.item.database.AbstractPagingItemReader} */ @SuppressWarnings("unchecked") public class IbatisDrivingQueryItemReader extends DrivingQueryItemReader { diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/KeyCollector.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/KeyCollector.java index bb5f3cc16..42e3791e5 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/KeyCollector.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/KeyCollector.java @@ -9,6 +9,8 @@ import org.springframework.batch.item.ExecutionContext; * * @author Lucas Ward * @see DrivingQueryItemReader + * @deprecated The DrivingQueryItemReader approach is not supported going forward, use a PagingItemReader + * implementation instead. See {@link org.springframework.batch.item.database.AbstractPagingItemReader} */ public interface KeyCollector { diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/IbatisKeyCollector.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/IbatisKeyCollector.java index 394636a29..ce8f1c050 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/IbatisKeyCollector.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/IbatisKeyCollector.java @@ -25,6 +25,8 @@ import com.ibatis.sqlmap.client.SqlMapClient; * @author Robert Kasanicky * @author Lucas Ward * @see DrivingQueryItemReader + * @deprecated The DrivingQueryItemReader approach is not supported going forward, use a PagingItemReader + * implementation instead. See {@link org.springframework.batch.item.database.AbstractPagingItemReader} */ public class IbatisKeyCollector extends ExecutionContextUserSupport implements KeyCollector { diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/MultipleColumnJdbcKeyCollector.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/MultipleColumnJdbcKeyCollector.java index f8432d600..dc18ba690 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/MultipleColumnJdbcKeyCollector.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/MultipleColumnJdbcKeyCollector.java @@ -52,6 +52,8 @@ import org.springframework.util.StringUtils; * * TODO this class has nothing to do with "multiple columns" other than default * values form keyMapper and preparedStatementSetter. This should be sorted out for 2.0 + * @deprecated The DrivingQueryItemReader approach is not supported going forward, use a PagingItemReader + * implementation instead. See {@link org.springframework.batch.item.database.AbstractPagingItemReader} */ public class MultipleColumnJdbcKeyCollector extends ExecutionContextUserSupport implements KeyCollector { diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/SingleColumnJdbcKeyCollector.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/SingleColumnJdbcKeyCollector.java index 708c88c69..bbf40af57 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/SingleColumnJdbcKeyCollector.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/SingleColumnJdbcKeyCollector.java @@ -51,6 +51,8 @@ import org.springframework.util.StringUtils; * * @author Lucas Ward * @see SingleColumnRowMapper + * @deprecated The DrivingQueryItemReader approach is not supported going forward, use a PagingItemReader + * implementation instead. See {@link org.springframework.batch.item.database.AbstractPagingItemReader} */ public class SingleColumnJdbcKeyCollector extends ExecutionContextUserSupport implements KeyCollector {