From 3d5c2b44e3e9978881abd393475e6f2cc0468ce7 Mon Sep 17 00:00:00 2001 From: dsyer Date: Mon, 21 Jan 2008 16:05:23 +0000 Subject: [PATCH] OPEN - issue BATCH-192: ScheduledJobIdentifier.scheduleDate can cause issues because it is java.util.Date http://jira.springframework.org/browse/BATCH-192 Add test for Timestamp in job parameters. --- .../repository/dao/AbstractJobDaoTests.java | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/spring-batch-execution/src/test/java/org/springframework/batch/execution/repository/dao/AbstractJobDaoTests.java b/spring-batch-execution/src/test/java/org/springframework/batch/execution/repository/dao/AbstractJobDaoTests.java index 33a2762ad..5199aec6f 100644 --- a/spring-batch-execution/src/test/java/org/springframework/batch/execution/repository/dao/AbstractJobDaoTests.java +++ b/spring-batch-execution/src/test/java/org/springframework/batch/execution/repository/dao/AbstractJobDaoTests.java @@ -16,6 +16,7 @@ package org.springframework.batch.execution.repository.dao; +import java.sql.Timestamp; import java.text.SimpleDateFormat; import java.util.Date; import java.util.List; @@ -305,6 +306,26 @@ public abstract class AbstractJobDaoTests extends } + public void testJobWithScheduledJobIdentifierAndDifferentDateImplementation() throws Exception { + Date date = new Date(); + ScheduledJobIdentifier jobIdentifier = new ScheduledJobIdentifier("Job1", "testKey", date); + + // Create job. + job = jobDao.createJob(jobIdentifier); + + Timestamp later = new Timestamp(date.getTime()); + ScheduledJobIdentifier laterIdentifier = new ScheduledJobIdentifier("Job1", "testKey", later); + + List jobs = jobDao.findJobs(laterIdentifier); + + // Different timestamp is different identifier... + assertEquals(1, jobs.size()); + assertEquals(job.getName(), ((JobInstance) jobs.get(0)).getName()); + assertEquals(jobIdentifier.getJobKey(), ((JobInstance) jobs.get(0)). + getIdentifier().getJobInstanceProperties().getString(DefaultJobIdentifier.JOB_KEY)); + + } + public void testFindJobExecutions(){ List results = jobDao.findJobExecutions(job);