From 4283291cc8b63e54b33230bcf0fbeb725bf9cd4e Mon Sep 17 00:00:00 2001 From: "David J. M. Karlsen" Date: Mon, 2 Sep 2013 10:17:55 +0200 Subject: [PATCH] use VARCHAR( n char) instead of VARCHAR(n) so semantics are used and not number of bytes. This is better when using multibyte charsets like UTF8 --- .../batch/core/schema-oracle10g.sql | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/spring-batch-core/src/main/resources/org/springframework/batch/core/schema-oracle10g.sql b/spring-batch-core/src/main/resources/org/springframework/batch/core/schema-oracle10g.sql index 62a8a5b81..b445e3579 100644 --- a/spring-batch-core/src/main/resources/org/springframework/batch/core/schema-oracle10g.sql +++ b/spring-batch-core/src/main/resources/org/springframework/batch/core/schema-oracle10g.sql @@ -3,8 +3,8 @@ CREATE TABLE BATCH_JOB_INSTANCE ( JOB_INSTANCE_ID NUMBER(19,0) NOT NULL PRIMARY KEY , VERSION NUMBER(19,0) , - JOB_NAME VARCHAR2(100) NOT NULL, - JOB_KEY VARCHAR2(32) NOT NULL, + JOB_NAME VARCHAR2(100 char) NOT NULL, + JOB_KEY VARCHAR2(32 char) NOT NULL, constraint JOB_INST_UN unique (JOB_NAME, JOB_KEY) ) ; @@ -15,20 +15,20 @@ CREATE TABLE BATCH_JOB_EXECUTION ( CREATE_TIME TIMESTAMP NOT NULL, START_TIME TIMESTAMP DEFAULT NULL , END_TIME TIMESTAMP DEFAULT NULL , - STATUS VARCHAR2(10) , - EXIT_CODE VARCHAR2(2500) , - EXIT_MESSAGE VARCHAR2(2500) , + STATUS VARCHAR2(10 char) , + EXIT_CODE VARCHAR2(2500 char) , + EXIT_MESSAGE VARCHAR2(2500 char) , LAST_UPDATED TIMESTAMP, - JOB_CONFIGURATION_LOCATION VARCHAR(2500) NULL, + JOB_CONFIGURATION_LOCATION VARCHAR(2500 char) NULL, constraint JOB_INST_EXEC_FK foreign key (JOB_INSTANCE_ID) references BATCH_JOB_INSTANCE(JOB_INSTANCE_ID) ) ; CREATE TABLE BATCH_JOB_EXECUTION_PARAMS ( JOB_EXECUTION_ID NUMBER(19,0) NOT NULL , - TYPE_CD VARCHAR2(6) NOT NULL , - KEY_NAME VARCHAR2(100) NOT NULL , - STRING_VAL VARCHAR2(250) , + TYPE_CD VARCHAR2(6 char) NOT NULL , + KEY_NAME VARCHAR2(100 char) NOT NULL , + STRING_VAL VARCHAR2(250 char) , DATE_VAL TIMESTAMP DEFAULT NULL , LONG_VAL NUMBER(19,0) , DOUBLE_VAL NUMBER , @@ -40,11 +40,11 @@ CREATE TABLE BATCH_JOB_EXECUTION_PARAMS ( CREATE TABLE BATCH_STEP_EXECUTION ( STEP_EXECUTION_ID NUMBER(19,0) NOT NULL PRIMARY KEY , VERSION NUMBER(19,0) NOT NULL, - STEP_NAME VARCHAR2(100) NOT NULL, + STEP_NAME VARCHAR2(100 char) NOT NULL, JOB_EXECUTION_ID NUMBER(19,0) NOT NULL, START_TIME TIMESTAMP NOT NULL , END_TIME TIMESTAMP DEFAULT NULL , - STATUS VARCHAR2(10) , + STATUS VARCHAR2(10 char) , COMMIT_COUNT NUMBER(19,0) , READ_COUNT NUMBER(19,0) , FILTER_COUNT NUMBER(19,0) , @@ -53,8 +53,8 @@ CREATE TABLE BATCH_STEP_EXECUTION ( WRITE_SKIP_COUNT NUMBER(19,0) , PROCESS_SKIP_COUNT NUMBER(19,0) , ROLLBACK_COUNT NUMBER(19,0) , - EXIT_CODE VARCHAR2(2500) , - EXIT_MESSAGE VARCHAR2(2500) , + EXIT_CODE VARCHAR2(2500 char) , + EXIT_MESSAGE VARCHAR2(2500 char) , LAST_UPDATED TIMESTAMP, constraint JOB_EXEC_STEP_FK foreign key (JOB_EXECUTION_ID) references BATCH_JOB_EXECUTION(JOB_EXECUTION_ID) @@ -62,7 +62,7 @@ CREATE TABLE BATCH_STEP_EXECUTION ( CREATE TABLE BATCH_STEP_EXECUTION_CONTEXT ( STEP_EXECUTION_ID NUMBER(19,0) NOT NULL PRIMARY KEY, - SHORT_CONTEXT VARCHAR2(2500) NOT NULL, + SHORT_CONTEXT VARCHAR2(2500 char) NOT NULL, SERIALIZED_CONTEXT CLOB , constraint STEP_EXEC_CTX_FK foreign key (STEP_EXECUTION_ID) references BATCH_STEP_EXECUTION(STEP_EXECUTION_ID) @@ -70,7 +70,7 @@ CREATE TABLE BATCH_STEP_EXECUTION_CONTEXT ( CREATE TABLE BATCH_JOB_EXECUTION_CONTEXT ( JOB_EXECUTION_ID NUMBER(19,0) NOT NULL PRIMARY KEY, - SHORT_CONTEXT VARCHAR2(2500) NOT NULL, + SHORT_CONTEXT VARCHAR2(2500 char) NOT NULL, SERIALIZED_CONTEXT CLOB , constraint JOB_EXEC_CTX_FK foreign key (JOB_EXECUTION_ID) references BATCH_JOB_EXECUTION(JOB_EXECUTION_ID)