diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/AbstractItemProcessingTasklet.java b/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/AbstractItemOrientedTasklet.java similarity index 91% rename from spring-batch-core/src/main/java/org/springframework/batch/core/step/item/AbstractItemProcessingTasklet.java rename to spring-batch-core/src/main/java/org/springframework/batch/core/step/item/AbstractItemOrientedTasklet.java index 93c37fa3d..9b08f2f7c 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/AbstractItemProcessingTasklet.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/AbstractItemOrientedTasklet.java @@ -21,7 +21,7 @@ import org.springframework.batch.item.ItemWriter; * @param input item type * @param output item type */ -public abstract class AbstractItemProcessingTasklet implements Tasklet { +public abstract class AbstractItemOrientedTasklet implements Tasklet { protected final Log logger = LogFactory.getLog(getClass()); @@ -33,7 +33,7 @@ public abstract class AbstractItemProcessingTasklet implements Tasklet { protected final MulticasterBatchListener listener = new MulticasterBatchListener(); - public AbstractItemProcessingTasklet(ItemReader itemReader, + public AbstractItemOrientedTasklet(ItemReader itemReader, ItemProcessor itemProcessor, ItemWriter itemWriter) { this.itemReader = itemReader; this.itemProcessor = itemProcessor; diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkOrientedTasklet.java b/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/FaultTolerantChunkOrientedTasklet.java similarity index 97% rename from spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkOrientedTasklet.java rename to spring-batch-core/src/main/java/org/springframework/batch/core/step/item/FaultTolerantChunkOrientedTasklet.java index 1efd3a3e2..819364878 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkOrientedTasklet.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/FaultTolerantChunkOrientedTasklet.java @@ -51,7 +51,7 @@ import org.springframework.core.AttributeAccessor; * @author Dave Syer * @author Robert Kasanicky */ -public class ChunkOrientedTasklet extends AbstractItemProcessingTasklet { +public class FaultTolerantChunkOrientedTasklet extends AbstractItemOrientedTasklet { private static final String INPUT_BUFFER_KEY = "INPUT_BUFFER_KEY"; @@ -70,7 +70,7 @@ public class ChunkOrientedTasklet extends AbstractItemProcessingTasklet rollbackClassifier; - public ChunkOrientedTasklet(ItemReader itemReader, + public FaultTolerantChunkOrientedTasklet(ItemReader itemReader, ItemProcessor itemProcessor, ItemWriter itemWriter, RepeatOperations chunkOperations, RetryOperations retryTemplate, Classifier rollbackClassifier, ItemSkipPolicy readSkipPolicy, @@ -197,7 +197,7 @@ public class ChunkOrientedTasklet extends AbstractItemProcessingTasklet extends AbstractItemProcessingTasklet { +public class SimpleChunkOrientedTasklet extends AbstractItemOrientedTasklet { private RepeatOperations repeatOperations; diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/SkipLimitStepFactoryBean.java b/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/SkipLimitStepFactoryBean.java index 042be8fdb..3f840eb5a 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/SkipLimitStepFactoryBean.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/step/item/SkipLimitStepFactoryBean.java @@ -248,7 +248,7 @@ public class SkipLimitStepFactoryBean extends SimpleStepFactoryBean exceptions.addAll(new ArrayList>(retryableExceptionClasses)); ItemSkipPolicy writeSkipPolicy = new LimitCheckingItemSkipPolicy(skipLimit, exceptions, new ArrayList>(fatalExceptionClasses)); - ChunkOrientedTasklet tasklet = new ChunkOrientedTasklet(getItemReader(), getItemProcessor(), + FaultTolerantChunkOrientedTasklet tasklet = new FaultTolerantChunkOrientedTasklet(getItemReader(), getItemProcessor(), getItemWriter(), getChunkOperations(), retryTemplate, rollbackClassifier, readSkipPolicy, writeSkipPolicy, writeSkipPolicy); tasklet.setListeners(getListeners()); diff --git a/spring-batch-core/src/test/java/org/springframework/batch/core/step/item/StatefulRetryTaskletTests.java b/spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantChunkOrientedTaskletTests.java similarity index 92% rename from spring-batch-core/src/test/java/org/springframework/batch/core/step/item/StatefulRetryTaskletTests.java rename to spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantChunkOrientedTaskletTests.java index 6524d2a33..ff58974c8 100644 --- a/spring-batch-core/src/test/java/org/springframework/batch/core/step/item/StatefulRetryTaskletTests.java +++ b/spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantChunkOrientedTaskletTests.java @@ -47,7 +47,7 @@ import org.springframework.batch.support.Classifier; * @author Dave Syer * */ -public class StatefulRetryTaskletTests { +public class FaultTolerantChunkOrientedTaskletTests { private Log logger = LogFactory.getLog(getClass()); @@ -61,7 +61,7 @@ public class StatefulRetryTaskletTests { private List processed = new ArrayList(); - private ChunkOrientedTasklet handler; + private FaultTolerantChunkOrientedTasklet handler; private RepeatTemplate chunkOperations = new RepeatTemplate(); @@ -109,7 +109,7 @@ public class StatefulRetryTaskletTests { @Test public void testBasicHandle() throws Exception { - handler = new ChunkOrientedTasklet(itemReader, itemProcessor, itemWriter, chunkOperations, + handler = new FaultTolerantChunkOrientedTasklet(itemReader, itemProcessor, itemWriter, chunkOperations, retryTemplate, rollbackClassifier, readSkipPolicy, writeSkipPolicy, writeSkipPolicy); StepContribution contribution = new StepExecution("foo", null).createStepContribution(); handler.execute(contribution, new BasicAttributeAccessor()); @@ -118,7 +118,7 @@ public class StatefulRetryTaskletTests { @Test public void testSkipOnRead() throws Exception { - handler = new ChunkOrientedTasklet(new ItemReader() { + handler = new FaultTolerantChunkOrientedTasklet(new ItemReader() { public Integer read() throws Exception, UnexpectedInputException, NoWorkFoundException, ParseException { throw new RuntimeException("Barf!"); } @@ -140,7 +140,7 @@ public class StatefulRetryTaskletTests { @Test public void testSkipSingleItemOnWrite() throws Exception { - handler = new ChunkOrientedTasklet(itemReader, itemProcessor, new ItemWriter() { + handler = new FaultTolerantChunkOrientedTasklet(itemReader, itemProcessor, new ItemWriter() { public void write(List items) throws Exception { written.addAll(items); throw new RuntimeException("Barf!"); @@ -165,7 +165,7 @@ public class StatefulRetryTaskletTests { @Test public void testSkipMultipleItemsOnWrite() throws Exception { - handler = new ChunkOrientedTasklet(itemReader, itemProcessor, new ItemWriter() { + handler = new FaultTolerantChunkOrientedTasklet(itemReader, itemProcessor, new ItemWriter() { public void write(List items) throws Exception { logger.debug("Writing items: " + items); written.addAll(items); @@ -217,7 +217,7 @@ public class StatefulRetryTaskletTests { @Test public void testSkipSingleItemOnProcess() throws Exception { - handler = new ChunkOrientedTasklet(itemReader, new ItemProcessor() { + handler = new FaultTolerantChunkOrientedTasklet(itemReader, new ItemProcessor() { public String process(Integer item) throws Exception { logger.debug("Processing item: " + item); processed.add(item); @@ -257,7 +257,7 @@ public class StatefulRetryTaskletTests { @Test public void testSkipOverLimitOnProcess() throws Exception { - handler = new ChunkOrientedTasklet(itemReader, new ItemProcessor() { + handler = new FaultTolerantChunkOrientedTasklet(itemReader, new ItemProcessor() { public String process(Integer item) throws Exception { logger.debug("Processing item: " + item); processed.add(item); diff --git a/spring-batch-core/src/test/java/org/springframework/batch/core/step/tasklet/SimpleChunkOrientedTasklet.java b/spring-batch-core/src/test/java/org/springframework/batch/core/step/tasklet/SimpleChunkOrientedTasklet.java index b44b51551..bca582d9d 100644 --- a/spring-batch-core/src/test/java/org/springframework/batch/core/step/tasklet/SimpleChunkOrientedTasklet.java +++ b/spring-batch-core/src/test/java/org/springframework/batch/core/step/tasklet/SimpleChunkOrientedTasklet.java @@ -15,7 +15,7 @@ */ package org.springframework.batch.core.step.tasklet; -import org.springframework.batch.core.step.item.ChunkOrientedTasklet; +import org.springframework.batch.core.step.item.FaultTolerantChunkOrientedTasklet; import org.springframework.batch.core.step.tasklet.Tasklet; import org.springframework.batch.item.ItemReader; import org.springframework.batch.item.ItemWriter; @@ -45,7 +45,7 @@ public class SimpleChunkOrientedTasklet extends org.springframework.batch.cor /** * Creates a {@link PassthroughItemProcessor} and uses it to create an - * instance of {@link ChunkOrientedTasklet}. + * instance of {@link FaultTolerantChunkOrientedTasklet}. */ public SimpleChunkOrientedTasklet(ItemReader itemReader, ItemWriter itemWriter) { super(itemReader, new PassthroughItemProcessor(), itemWriter, repeatTemplate); @@ -53,7 +53,7 @@ public class SimpleChunkOrientedTasklet extends org.springframework.batch.cor /** * Creates a {@link PassthroughItemProcessor} and uses it to create an - * instance of {@link ChunkOrientedTasklet}. + * instance of {@link FaultTolerantChunkOrientedTasklet}. */ public SimpleChunkOrientedTasklet(ItemReader itemReader, ItemWriter itemWriter, RepeatOperations repeatOperations) { super(itemReader, new PassthroughItemProcessor(), itemWriter, repeatOperations);