From 488ba7a37b70c62a2ac40d6c945ea940408add80 Mon Sep 17 00:00:00 2001 From: Robert Kasanicky Date: Sun, 20 Nov 2011 21:21:51 +0100 Subject: [PATCH] RESOLVED - BATCH-1815: RunIdIncrementer goes against java best practices --- .../batch/core/launch/support/RunIdIncrementer.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/launch/support/RunIdIncrementer.java b/spring-batch-core/src/main/java/org/springframework/batch/core/launch/support/RunIdIncrementer.java index a31173b35..6bea1f53d 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/launch/support/RunIdIncrementer.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/launch/support/RunIdIncrementer.java @@ -41,11 +41,11 @@ public class RunIdIncrementer implements JobParametersIncrementer { * Increment the run.id parameter (starting with 1). */ public JobParameters getNext(JobParameters parameters) { - if (parameters == null) { - parameters = new JobParameters(); - } - long id = parameters.getLong(key, 0L) + 1; - return new JobParametersBuilder(parameters).addLong(key, id).toJobParameters(); + + JobParameters params = (parameters == null) ? new JobParameters() : parameters; + + long id = params.getLong(key, 0L) + 1; + return new JobParametersBuilder(params).addLong(key, id).toJobParameters(); } }