From 570a86ee6d43b83156ed4e8e51e3c5446ee4cd49 Mon Sep 17 00:00:00 2001 From: lucasward Date: Wed, 5 Sep 2007 04:00:27 +0000 Subject: [PATCH] Fix for Batch-123:SimpleJobIdentifier does not implement equals/hashcode. --- .../batch/core/runtime/SimpleJobIdentifier.java | 10 ++++++++++ .../batch/core/runtime/SimpleJobIdentifierTests.java | 4 ++++ 2 files changed, 14 insertions(+) diff --git a/core/src/main/java/org/springframework/batch/core/runtime/SimpleJobIdentifier.java b/core/src/main/java/org/springframework/batch/core/runtime/SimpleJobIdentifier.java index 01d06f832..2167472ee 100644 --- a/core/src/main/java/org/springframework/batch/core/runtime/SimpleJobIdentifier.java +++ b/core/src/main/java/org/springframework/batch/core/runtime/SimpleJobIdentifier.java @@ -15,6 +15,9 @@ */ package org.springframework.batch.core.runtime; +import org.apache.commons.lang.builder.EqualsBuilder; +import org.apache.commons.lang.builder.HashCodeBuilder; + /** * @author Dave Syer @@ -62,4 +65,11 @@ public class SimpleJobIdentifier implements JobIdentifier { return "name=" + name; } + public boolean equals(Object obj) { + return EqualsBuilder.reflectionEquals(this, obj); + } + + public int hashCode() { + return HashCodeBuilder.reflectionHashCode(this); + } } diff --git a/core/src/test/java/org/springframework/batch/core/runtime/SimpleJobIdentifierTests.java b/core/src/test/java/org/springframework/batch/core/runtime/SimpleJobIdentifierTests.java index 1d540fa9c..1223fa8fc 100644 --- a/core/src/test/java/org/springframework/batch/core/runtime/SimpleJobIdentifierTests.java +++ b/core/src/test/java/org/springframework/batch/core/runtime/SimpleJobIdentifierTests.java @@ -52,4 +52,8 @@ public class SimpleJobIdentifierTests extends TestCase { .indexOf("name=") >= 0); } + public void testEquals(){ + SimpleJobIdentifier testIdentifier = new SimpleJobIdentifier("foo"); + assertEquals(testIdentifier,identifier); + } }