Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Support empty delimiter in DelimitedBuilder of FlatFileItemWriterBuilder

Browse Source 
Previously, if supplying an empty delimiter, to the delimited().delimiter() of DelimitedBuilder from the parent FlatFileItemWriterBuilder, it would be ignored and instead use the default delimiter ",".

Resolves BATCH-2844
This commit is contained in:
Drummond Dawson
2019-10-02 22:23:34 -04:00
committed by Mahmoud Ben Hassine
parent 44c0b8d557
commit 62a2e65e20
2 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/builder/FlatFileItemWriterBuilder.java
View File

@@ -33,7 +33,6 @@ import org.springframework.batch.item.file.transform.FormatterLineAggregator;
import org.springframework.batch.item.file.transform.LineAggregator;
import org.springframework.core.io.Resource;
import org.springframework.util.Assert;
import org.springframework.util.StringUtils;
/**
* A builder implementation for the {@link FlatFileItemWriter}
@@ -464,9 +463,7 @@ public class FlatFileItemWriterBuilder<T> {
"A list of field names or a field extractor is required");
DelimitedLineAggregator<T> delimitedLineAggregator = new DelimitedLineAggregator<>();
if (StringUtils.hasLength(this.delimiter)) {
delimitedLineAggregator.setDelimiter(this.delimiter);
}
delimitedLineAggregator.setDelimiter(this.delimiter);
if (this.fieldExtractor == null) {
BeanWrapperFieldExtractor<T> beanWrapperFieldExtractor = new BeanWrapperFieldExtractor<>();