diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/step/ItemSkipPolicyItemHandler.java b/spring-batch-core/src/main/java/org/springframework/batch/core/step/ItemSkipPolicyItemHandler.java index da0aa10ad..d6e81221d 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/step/ItemSkipPolicyItemHandler.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/step/ItemSkipPolicyItemHandler.java @@ -74,10 +74,8 @@ public class ItemSkipPolicyItemHandler extends SimpleItemHandler { contribution.incrementSkipCount(); skip(); } - else { - // Rethrow so that outer transaction is rolled back properly - throw e; - } + // Rethrow so that outer transaction is rolled back properly + throw e; } diff --git a/spring-batch-samples/src/main/resources/jobs/rollbackJob.xml b/spring-batch-samples/src/main/resources/jobs/rollbackJob.xml index 358df01e2..3d58652e6 100644 --- a/spring-batch-samples/src/main/resources/jobs/rollbackJob.xml +++ b/spring-batch-samples/src/main/resources/jobs/rollbackJob.xml @@ -9,13 +9,12 @@ http://www.springframework.org/schema/aop/spring-aop-2.0.xsd"> - - + 4 written to output + assertEquals(before + 4, after); } - - + }