From 69615714069d13b09976f0a3d001f2d4ba6fd352 Mon Sep 17 00:00:00 2001
From: yeonnex <yeonnex@gmail.com>
Date: Fri, 11 Oct 2024 20:17:06 +0900
Subject: [PATCH] Fix variable usage in ScriptItemProcessorTests

This commit also adds test dependencies for groovy,
javascript, bean shell and jruby script engines.
---
 pom.xml                                       |  4 ++++
 spring-batch-infrastructure/pom.xml           | 24 +++++++++++++++++++
 .../support/ScriptItemProcessorTests.java     |  4 ++--
 3 files changed, 30 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 4aa29bb28..d297febf6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -129,6 +129,10 @@
 		<jtds.version>1.3.1</jtds.version>
 		<testcontainers.version>1.20.4</testcontainers.version>
 		<jsonassert.version>1.5.3</jsonassert.version>
+		<groovy-jsr223.version>4.0.23</groovy-jsr223.version>
+		<nashorn.version>15.4</nashorn.version>
+		<beanshell.version>2.0b6</beanshell.version>
+		<jruby.version>9.4.8.0</jruby.version>
 
 		<!-- samples dependencies -->
 		<spring-rabbit.version>${spring-amqp.version}</spring-rabbit.version>
diff --git a/spring-batch-infrastructure/pom.xml b/spring-batch-infrastructure/pom.xml
index dd208f837..1f00352b3 100644
--- a/spring-batch-infrastructure/pom.xml
+++ b/spring-batch-infrastructure/pom.xml
@@ -529,6 +529,30 @@
 			<version>${angus-mail.version}</version>
 			<scope>test</scope>
 		</dependency>
+		<dependency>
+			<groupId>org.apache.groovy</groupId>
+			<artifactId>groovy-jsr223</artifactId>
+			<version>${groovy-jsr223.version}</version>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.openjdk.nashorn</groupId>
+			<artifactId>nashorn-core</artifactId>
+			<version>${nashorn.version}</version>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.apache-extras.beanshell</groupId>
+			<artifactId>bsh</artifactId>
+			<version>${beanshell.version}</version>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.jruby</groupId>
+			<artifactId>jruby</artifactId>
+			<version>${jruby.version}</version>
+			<scope>test</scope>
+		</dependency>
 
 		<!-- provided dependencies -->
 		<dependency>
diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/ScriptItemProcessorTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/ScriptItemProcessorTests.java
index bdbb6205c..5370d7b74 100644
--- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/ScriptItemProcessorTests.java
+++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/ScriptItemProcessorTests.java
@@ -82,7 +82,7 @@ class ScriptItemProcessorTests {
 		assumeTrue(languageExists("jruby"));
 
 		ScriptItemProcessor<String, Object> scriptItemProcessor = new ScriptItemProcessor<>();
-		scriptItemProcessor.setScriptSource("$item.upcase", "jruby");
+		scriptItemProcessor.setScriptSource("item.upcase", "jruby");
 		scriptItemProcessor.afterPropertiesSet();
 
 		assertEquals("SS", scriptItemProcessor.process("ss"), "Incorrect transformed value");
@@ -93,7 +93,7 @@ class ScriptItemProcessorTests {
 		assumeTrue(languageExists("jruby"));
 
 		ScriptItemProcessor<String, Object> scriptItemProcessor = new ScriptItemProcessor<>();
-		scriptItemProcessor.setScriptSource("def process(item) $item.upcase end \n process($item)", "jruby");
+		scriptItemProcessor.setScriptSource("def process(item) item.upcase end \n process(item)", "jruby");
 		scriptItemProcessor.afterPropertiesSet();
 
 		assertEquals("SS", scriptItemProcessor.process("ss"), "Incorrect transformed value");