diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/item/reader/OrderItemReader.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/item/reader/OrderItemReader.java index cfe26c177..c224585fe 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/item/reader/OrderItemReader.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/item/reader/OrderItemReader.java @@ -24,7 +24,6 @@ import org.springframework.batch.core.domain.StepExecution; import org.springframework.batch.io.file.mapping.FieldSet; import org.springframework.batch.io.file.mapping.FieldSetMapper; import org.springframework.batch.item.reader.DelegatingItemReader; -import org.springframework.batch.item.validator.Validator; import org.springframework.batch.sample.domain.Address; import org.springframework.batch.sample.domain.BillingInfo; import org.springframework.batch.sample.domain.Customer; @@ -55,8 +54,6 @@ public class OrderItemReader extends DelegatingItemReader { private FieldSetMapper shippingMapper; - private Validator validator; - /** * @throws Exception * @see org.springframework.batch.item.ItemReader#read() @@ -68,11 +65,8 @@ public class OrderItemReader extends DelegatingItemReader { process((FieldSet) super.read()); } - if (order != null) { - log.info("Mapped: " + order); - validator.validate(order); - } - + log.info("Mapped: " + order); + Object result = order; order = null; @@ -204,8 +198,4 @@ public class OrderItemReader extends DelegatingItemReader { this.shippingMapper = shippingMapper; } - public void setValidator(Validator validator) { - this.validator = validator; - } - } diff --git a/spring-batch-samples/src/main/resources/jobs/multilineOrderJob.xml b/spring-batch-samples/src/main/resources/jobs/multilineOrderJob.xml index 254227da7..664501ffd 100644 --- a/spring-batch-samples/src/main/resources/jobs/multilineOrderJob.xml +++ b/spring-batch-samples/src/main/resources/jobs/multilineOrderJob.xml @@ -1,7 +1,7 @@ - - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + 0 AND ? <= 9999999999 : 'Incorrect order ID' : 'error.order.id' } { orderDate : isFutureDate(?) = FALSE : 'Future date is not allowed' : 'error.order.date.future' } @@ -131,41 +136,41 @@ - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/spring-batch-samples/src/test/java/org/springframework/batch/sample/item/reader/OrderItemReaderTests.java b/spring-batch-samples/src/test/java/org/springframework/batch/sample/item/reader/OrderItemReaderTests.java index e8699d775..ab1a36c1e 100644 --- a/spring-batch-samples/src/test/java/org/springframework/batch/sample/item/reader/OrderItemReaderTests.java +++ b/spring-batch-samples/src/test/java/org/springframework/batch/sample/item/reader/OrderItemReaderTests.java @@ -9,14 +9,12 @@ import org.springframework.batch.io.file.mapping.DefaultFieldSet; import org.springframework.batch.io.file.mapping.FieldSet; import org.springframework.batch.io.file.mapping.FieldSetMapper; import org.springframework.batch.item.ItemReader; -import org.springframework.batch.item.validator.Validator; import org.springframework.batch.sample.domain.Address; import org.springframework.batch.sample.domain.BillingInfo; import org.springframework.batch.sample.domain.Customer; import org.springframework.batch.sample.domain.LineItem; import org.springframework.batch.sample.domain.Order; import org.springframework.batch.sample.domain.ShippingInfo; -import org.springframework.batch.sample.item.reader.OrderItemReader; public class OrderItemReaderTests extends TestCase { @@ -25,8 +23,6 @@ public class OrderItemReaderTests extends TestCase { private ItemReader input; private MockControl mapperControl; private FieldSetMapper mapper; - private MockControl validatorControl; - private Validator validator; public void setUp() { @@ -110,16 +106,8 @@ public class OrderItemReaderTests extends TestCase { mapperControl.setReturnValue(item,3); mapperControl.replay(); - //create mock validator - validatorControl = MockControl.createControl(Validator.class); - validator = (Validator)validatorControl.getMock(); - validator.validate(null); - validatorControl.setMatcher(MockControl.ALWAYS_MATCHER); - validatorControl.setVoidCallable(1); - validatorControl.replay(); - //set-up provider: set mappers and validator - provider.setValidator(validator); + //set-up provider: set mappers provider.setAddressMapper(mapper); provider.setBillingMapper(mapper); provider.setCustomerMapper(mapper); @@ -158,7 +146,6 @@ public class OrderItemReaderTests extends TestCase { //verify method calls on input source, mapper and validator inputControl.verify(); mapperControl.verify(); - validatorControl.verify(); } }