Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - issue BATCH-305: ItemProvider still referenced in comments / variable naming in ItemOrientedTasklet

Browse Source 
http://jira.springframework.org/browse/BATCH-305
This commit is contained in:
dsyer
2008-01-24 10:42:31 +00:00
parent f23b09c556
commit 702213838e
6 changed files with 48 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-batch-execution/src/main/java/org/springframework/batch/execution/tasklet/ItemOrientedTasklet.java
View File

@@ -40,7 +40,7 @@ import org.springframework.util.Assert;
* A concrete implementation of the {@link Tasklet} interface that provides
* 'split processing'. This type of processing is characterized by separating
* the reading and processing of batch data into two separate classes:
* ItemProvider and ItemProcessor. The ItemProvider class provides a solid means
* {@link ItemReader} and {@link ItemProcessor}. The {@link ItemReader} class provides a solid means
* for re-usability and enforces good architecture practices. Because an object
* <em>must</em> be returned by the {@link ItemReader} to continue
* processing, (returning null indicates processing should end) a developer is
@@ -108,7 +108,7 @@ public class ItemOrientedTasklet implements Tasklet, Skippable,
* @see org.springframework.beans.factory.InitializingBean#afterPropertiesSet()
*/
public void afterPropertiesSet() throws Exception {
Assert.notNull(itemProvider, "ItemProvider must be provided");
Assert.notNull(itemProvider, "ItemReader must be provided");
Assert.notNull(itemProcessor, "ItemProcessor must be provided");
if (itemRecoverer == null && (itemProvider instanceof ItemRecoverer)) {

2
spring-batch-execution/src/test/java/org/springframework/batch/execution/tasklet/ItemOrientedTaskletTests.java
View File

@@ -282,7 +282,7 @@ public class ItemOrientedTaskletTests extends TestCase {
try {
module.afterPropertiesSet();
} catch (IllegalArgumentException e) {
assertTrue(e.getMessage().toLowerCase().indexOf("provider") >= 0);
assertTrue(e.getMessage().toLowerCase().indexOf("reader") >= 0);
}
}