Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - issue BATCH-305: ItemProvider still referenced in comments / variable naming in ItemOrientedTasklet

Browse Source 
http://jira.springframework.org/browse/BATCH-305
This commit is contained in:
dsyer
2008-01-24 10:42:31 +00:00
parent f23b09c556
commit 702213838e
6 changed files with 48 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/reader/DelegatingItemReaderIntegrationTests.java
View File

@@ -4,7 +4,6 @@ import java.util.ArrayList;
import java.util.List;
import org.springframework.batch.io.sample.domain.FooService;
import org.springframework.batch.item.reader.ItemReaderAdapter;
import org.springframework.test.AbstractDependencyInjectionSpringContextTests;
/**
@@ -15,34 +14,33 @@ import org.springframework.test.AbstractDependencyInjectionSpringContextTests;
public class DelegatingItemReaderIntegrationTests extends AbstractDependencyInjectionSpringContextTests {
private ItemReaderAdapter provider;
private FooService fooService;
protected String getConfigPath() {
return "delegating-item-provider.xml";
}
/**
* Regular usage scenario - items are retrieved from
* the service injected invoker points to.
*/
* Regular usage scenario - items are retrieved from the service injected
* invoker points to.
*/
public void testNext() throws Exception {
List returnedItems = new ArrayList();
Object item;
while ((item = provider.read()) != null) {
returnedItems.add(item);
}
List input = fooService.getGeneratedFoos();
assertEquals(input.size(), returnedItems.size());
assertFalse(returnedItems.isEmpty());
for (int i = 0; i<input.size(); i++) {
for (int i = 0; i < input.size(); i++) {
assertSame(input.get(i), returnedItems.get(i));
}
}
/**
* getKey(..) is implemented trivially.
*/
@@ -50,13 +48,6 @@ public class DelegatingItemReaderIntegrationTests extends AbstractDependencyInje
Object item = new Object();
assertSame(item, provider.getKey(item));
}
/**
* Recover not supported.
*/
public void testRecover() {
assertFalse(provider.recover(null, null));
}
public void setProvider(ItemReaderAdapter provider) {
this.provider = provider;
@@ -65,6 +56,5 @@ public class DelegatingItemReaderIntegrationTests extends AbstractDependencyInje
public void setFooService(FooService fooService) {
this.fooService = fooService;
}
}