Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

IN PROGRESS - BATCH-85: Many warnings in Javadocs (e.g. missing links and parameter names)

Browse Source 
cleaned up infrastructure module
This commit is contained in:
robokaso
2008-04-22 09:26:10 +00:00
parent 91e5467279
commit 7e41ff0381
74 changed files with 214 additions and 249 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/HibernateAwareItemWriterTests.java
View File

@@ -90,7 +90,7 @@ public class HibernateAwareItemWriterTests extends TestCase {
/**
* Test method for
* {@link org.springframework.batch.item.database.HibernateAwareItemWriter#initDao()}.
* {@link org.springframework.batch.item.database.HibernateAwareItemWriter#afterPropertiesSet()}.
*
* @throws Exception
*/
@@ -108,7 +108,7 @@ public class HibernateAwareItemWriterTests extends TestCase {
/**
* Test method for
* {@link org.springframework.batch.item.database.HibernateAwareItemWriter#initDao()}.
* {@link org.springframework.batch.item.database.HibernateAwareItemWriter#afterPropertiesSet()}.
*
* @throws Exception
*/
@@ -183,7 +183,7 @@ public class HibernateAwareItemWriterTests extends TestCase {
/**
* Test method for
* {@link org.springframework.batch.item.database.HibernateAwareItemWriter#close(org.springframework.batch.repeat.RepeatContext)}.
* {@link org.springframework.batch.item.database.HibernateAwareItemWriter#flush()}.
*/
public void testFlush() throws Exception{
writer.flush();
@@ -195,7 +195,7 @@ public class HibernateAwareItemWriterTests extends TestCase {
/**
* Test method for
* {@link org.springframework.batch.item.database.HibernateAwareItemWriter#close(org.springframework.batch.repeat.RepeatContext)}.
* {@link org.springframework.batch.item.database.HibernateAwareItemWriter#clear()}.
*/
public void testClear() throws Exception{
writer.clear();

22
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/SimpleStreamManagerTests.java → spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/CompositeItemStreamTests.java
View File

@@ -30,16 +30,12 @@ import org.springframework.batch.item.support.CompositeItemStream;
* @author Dave Syer
*
*/
public class SimpleStreamManagerTests extends TestCase {
public class CompositeItemStreamTests extends TestCase {
private CompositeItemStream manager = new CompositeItemStream();
private List list = new ArrayList();
/**
* Test method for
* {@link org.springframework.batch.item.support.CompositeItemStream#commit(org.springframework.transaction.TransactionStatus)}.
*/
public void testRegisterAndOpen() {
ItemStreamSupport stream = new ItemStreamSupport() {
public void open(ExecutionContext executionContext) throws ItemStreamException {
@@ -51,10 +47,6 @@ public class SimpleStreamManagerTests extends TestCase {
assertEquals(1, list.size());
}
/**
* Test method for
* {@link org.springframework.batch.item.support.CompositeItemStream#commit(org.springframework.transaction.TransactionStatus)}.
*/
public void testRegisterTwice() {
ItemStreamSupport stream = new ItemStreamSupport() {
public void open(ExecutionContext executionContext) throws ItemStreamException {
@@ -67,10 +59,6 @@ public class SimpleStreamManagerTests extends TestCase {
assertEquals(1, list.size());
}
/**
* Test method for
* {@link org.springframework.batch.item.support.CompositeItemStream#commit(org.springframework.transaction.TransactionStatus)}.
*/
public void testMark() {
manager.register(new ItemStreamSupport() {
public void update(ExecutionContext executionContext) {
@@ -81,10 +69,6 @@ public class SimpleStreamManagerTests extends TestCase {
assertEquals(1, list.size());
}
/**
* Test method for
* {@link org.springframework.batch.item.support.CompositeItemStream#commit(org.springframework.transaction.TransactionStatus)}.
*/
public void testClose() {
manager.register(new ItemStreamSupport() {
public void close(ExecutionContext executionContext) throws ItemStreamException {
@@ -95,10 +79,6 @@ public class SimpleStreamManagerTests extends TestCase {
assertEquals(1, list.size());
}
/**
* Test method for
* {@link org.springframework.batch.item.support.CompositeItemStream#commit(org.springframework.transaction.TransactionStatus)}.
*/
public void testCloseDoesNotUnregister() {
manager.setStreams(new ItemStream[] { new ItemStreamSupport() {
public void open(ExecutionContext executionContext) throws ItemStreamException {

6
spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/ExitStatusTests.java
View File

@@ -27,7 +27,7 @@ public class ExitStatusTests extends TestCase {
/**
* Test method for
* {@link org.springframework.batch.repeat.ExitStatus#ExitStatus(boolean, int)}.
* {@link org.springframework.batch.repeat.ExitStatus#ExitStatus(boolean, String)}.
*/
public void testExitStatusBooleanInt() {
ExitStatus status = new ExitStatus(true, "10");
@@ -37,7 +37,7 @@ public class ExitStatusTests extends TestCase {
/**
* Test method for
* {@link org.springframework.batch.repeat.ExitStatus#ExitStatus(boolean, int)}.
* {@link org.springframework.batch.repeat.ExitStatus#ExitStatus(boolean, String)}.
*/
public void testExitStatusConstantsContinuable() {
ExitStatus status = ExitStatus.CONTINUABLE;
@@ -47,7 +47,7 @@ public class ExitStatusTests extends TestCase {
/**
* Test method for
* {@link org.springframework.batch.repeat.ExitStatus#ExitStatus(boolean, int)}.
* {@link org.springframework.batch.repeat.ExitStatus#ExitStatus(boolean, String)}.
*/
public void testExitStatusConstantsFinished() {
ExitStatus status = ExitStatus.FINISHED;

13
spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/listener/CompositeRepeatListenerTests.java
View File

@@ -36,8 +36,7 @@ public class CompositeRepeatListenerTests extends TestCase {
private List list = new ArrayList();
/**
* Test method for
* {@link org.springframework.batch.execution.listener.CompositeStepListener#setListeners(org.springframework.batch.core.domain.StepListener[])}.
* Test method for {@link CompositeRepeatListener#setListeners(RepeatListener[])}.
*/
public void testSetListeners() {
listener.setListeners(new RepeatListener[] { new RepeatListenerSupport() {
@@ -55,7 +54,7 @@ public class CompositeRepeatListenerTests extends TestCase {
/**
* Test method for
* {@link org.springframework.batch.execution.listener.CompositeStepListener#registerListener(org.springframework.batch.core.domain.StepListener)}.
* {@link CompositeRepeatListener#register(RepeatListener)}.
*/
public void testSetListener() {
listener.register(new RepeatListenerSupport() {
@@ -67,10 +66,6 @@ public class CompositeRepeatListenerTests extends TestCase {
assertEquals(1, list.size());
}
/**
* Test method for
* {@link org.springframework.batch.execution.listener.CompositeStepListener#beforeStep(StepExecution)}.
*/
public void testClose() {
listener.register(new RepeatListenerSupport() {
public void close(RepeatContext context) {
@@ -81,10 +76,6 @@ public class CompositeRepeatListenerTests extends TestCase {
assertEquals(1, list.size());
}
/**
* Test method for
* {@link org.springframework.batch.execution.listener.CompositeStepListener#beforeStep(StepExecution)}.
*/
public void testOnError() {
listener.register(new RepeatListenerSupport() {
public void onError(RepeatContext context, Throwable e) {

2
spring-batch-infrastructure/src/test/java/org/springframework/batch/retry/StubItemKeyGeneratorRecoverer.java
View File

@@ -24,7 +24,7 @@ public class StubItemKeyGeneratorRecoverer implements ItemRecoverer, ItemKeyGene
/**
* Do nothing. Subclassses should override to implement recovery behaviour.
*
* @see org.springframework.batch.item.ItemReader#recover(java.lang.Object,
* @see org.springframework.batch.item.ItemRecoverer#recover(java.lang.Object,
* Throwable)
*
* @return false if nothing can be done (the default), or true if the item

2
spring-batch-infrastructure/src/test/java/org/springframework/batch/retry/support/RetrySynchronizationManagerTests.java
View File

@@ -84,8 +84,6 @@ public class RetrySynchronizationManagerTests extends TestCase {
/**
* Clear all contexts starting with the current one and continuing until
* {@link RetrySynchronizationManager#clear()} returns null.
*
* @return
*/
public static RetryContext clearAll() {
RetryContext result = null;