Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve String concatenation where appropriate

Browse Source
This commit is contained in:
Mahmoud Ben Hassine
2023-06-05 13:19:28 +02:00
parent 106c4a589d
commit 8070751da8
6 changed files with 26 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/order/internal/OrderLineAggregator.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2006-2007 the original author or authors.
* Copyright 2006-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -38,13 +38,13 @@ public class OrderLineAggregator implements LineAggregator<Order> {
public String aggregate(Order order) {
StringBuilder result = new StringBuilder();
result.append(aggregators.get("header").aggregate(order) + LINE_SEPARATOR);
result.append(aggregators.get("customer").aggregate(order) + LINE_SEPARATOR);
result.append(aggregators.get("address").aggregate(order) + LINE_SEPARATOR);
result.append(aggregators.get("billing").aggregate(order) + LINE_SEPARATOR);
result.append(aggregators.get("header").aggregate(order)).append(LINE_SEPARATOR);
result.append(aggregators.get("customer").aggregate(order)).append(LINE_SEPARATOR);
result.append(aggregators.get("address").aggregate(order)).append(LINE_SEPARATOR);
result.append(aggregators.get("billing").aggregate(order)).append(LINE_SEPARATOR);
for (LineItem lineItem : order.getLineItems()) {
result.append(aggregators.get("item").aggregate(lineItem) + LINE_SEPARATOR);
result.append(aggregators.get("item").aggregate(lineItem)).append(LINE_SEPARATOR);
}
result.append(aggregators.get("footer").aggregate(order));

8
spring-batch-samples/src/test/java/org/springframework/batch/sample/CompositeItemWriterSampleFunctionalTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2008-2022 the original author or authors.
* Copyright 2008-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -106,12 +106,12 @@ class CompositeItemWriterSampleFunctionalTests {
private void checkOutputFile(String fileName) throws IOException {
List<String> outputLines = IOUtils.readLines(new FileInputStream(fileName), "UTF-8");
String output = "";
StringBuilder output = new StringBuilder();
for (String line : outputLines) {
output += line;
output.append(line);
}
assertEquals(EXPECTED_OUTPUT_FILE, output);
assertEquals(EXPECTED_OUTPUT_FILE, output.toString());
}
}