diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/Player.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/Player.java index 69f4e6c85..dfd9e5ef2 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/Player.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/Player.java @@ -4,7 +4,7 @@ import java.io.Serializable; public class Player implements Serializable { - private String ID; + private String id; private String lastName; private String firstName; private String position; @@ -13,14 +13,14 @@ public class Player implements Serializable { public String toString() { - return "PLAYER:ID=" + ID + ",Last Name=" + lastName + + return "PLAYER:id=" + id + ",Last Name=" + lastName + ",First Name=" + firstName + ",Position=" + position + ",Birth Year=" + birthYear + ",DebutYear=" + debutYear; } - public String getID() { - return ID; + public String getId() { + return id; } public String getLastName() { return lastName; @@ -37,8 +37,8 @@ public class Player implements Serializable { public int getDebutYear() { return debutYear; } - public void setID(String id) { - ID = id; + public void setId(String id) { + this.id = id; } public void setLastName(String lastName) { this.lastName = lastName; diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/JdbcPlayerDao.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/JdbcPlayerDao.java index 1644a4c0f..3d665e2c0 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/JdbcPlayerDao.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/JdbcPlayerDao.java @@ -6,7 +6,7 @@ package org.springframework.batch.sample.domain.football.internal; import org.springframework.batch.sample.domain.football.Player; import org.springframework.batch.sample.domain.football.PlayerDao; import org.springframework.jdbc.core.simple.SimpleJdbcDaoSupport; -import org.springframework.jdbc.core.namedparam.MapSqlParameterSource; +import org.springframework.jdbc.core.namedparam.BeanPropertySqlParameterSource; /** * @author Lucas Ward @@ -21,13 +21,7 @@ public class JdbcPlayerDao extends SimpleJdbcDaoSupport implements PlayerDao { public void savePlayer(Player player) { getSimpleJdbcTemplate().update(INSERT_PLAYER, - // ToDo: new BeanPropertySqlParameterSource(player)); - new MapSqlParameterSource() - .addValue("id", player.getID()) - .addValue("lastName", player.getLastName()) - .addValue("firstName",player.getFirstName()) - .addValue("position", player.getPosition()) - .addValue("birthYear", player.getBirthYear()) - .addValue("debutYear", player.getDebutYear())); + new BeanPropertySqlParameterSource(player)); + } } diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/PlayerFieldSetMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/PlayerFieldSetMapper.java index 394e0ca56..9fe7b0b01 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/PlayerFieldSetMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/PlayerFieldSetMapper.java @@ -13,7 +13,7 @@ public class PlayerFieldSetMapper implements FieldSetMapper { } Player player = new Player(); - player.setID(fs.readString("ID")); + player.setId(fs.readString("ID")); player.setLastName(fs.readString("lastName")); player.setFirstName(fs.readString("firstName")); player.setPosition(fs.readString("position")); diff --git a/spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/football/internal/JdbcPlayerDaoIntegrationTests.java b/spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/football/internal/JdbcPlayerDaoIntegrationTests.java index cad3c2d3e..78547c77a 100644 --- a/spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/football/internal/JdbcPlayerDaoIntegrationTests.java +++ b/spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/football/internal/JdbcPlayerDaoIntegrationTests.java @@ -57,7 +57,7 @@ public class JdbcPlayerDaoIntegrationTests { playerDao.setDataSource(dataSource); player = new Player(); - player.setID("AKFJDL00"); + player.setId("AKFJDL00"); player.setFirstName("John"); player.setLastName("Doe"); player.setPosition("QB");