RESOLVED - BATCH-1138: Add "parent" attribute to <job/>

spring-batch-core/src/test/java/org/springframework/batch/core/configuration/xml/DummyAnnotationJobExecutionListener.java

@@ -0,0 +1,15 @@
+package org.springframework.batch.core.configuration.xml;
+
+import org.springframework.batch.core.annotation.BeforeJob;
+
+/**
+ * @author Dan Garrette
+ * @since 2.0
+ */
+public class DummyAnnotationJobExecutionListener {
+
+	@BeforeJob
+	public void execute() {
+	}
+
+}

spring-batch-core/src/test/java/org/springframework/batch/core/configuration/xml/JobParserTests.java

@@ -0,0 +1,104 @@
+/*
+ * Copyright 2006-2009 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.batch.core.configuration.xml;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import java.lang.reflect.Field;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import org.junit.Test;
+import org.springframework.aop.framework.Advised;
+import org.springframework.batch.core.Job;
+import org.springframework.batch.core.JobExecutionListener;
+import org.springframework.batch.core.job.AbstractJob;
+import org.springframework.batch.core.listener.CompositeExecutionJobListener;
+import org.springframework.batch.core.listener.JobExecutionListenerSupport;
+import org.springframework.context.ConfigurableApplicationContext;
+import org.springframework.context.support.ClassPathXmlApplicationContext;
+
+/**
+ * @author Dan Garrette
+ * @since 2.0
+ */
+public class JobParserTests {
+
+	@SuppressWarnings("unchecked")
+	@Test
+	public void testJobParserParentAttribute() throws Exception {
+		ConfigurableApplicationContext ctx = new ClassPathXmlApplicationContext(
+				"org/springframework/batch/core/configuration/xml/JobParserParentAttributeTests-context.xml");
+		Map<String, Object> beans = ctx.getBeansOfType(Job.class);
+
+		assertTrue(beans.containsKey("job1"));
+		Job job1 = (Job) ctx.getBean("job1");
+		List<?> job1Listeners = getListeners(job1);
+		assertEquals(2, job1Listeners.size());
+		boolean a = false;
+		boolean b = false;
+		for (Object l : job1Listeners) {
+			if (l instanceof DummyAnnotationJobExecutionListener) {
+				a = true;
+			}
+			else if (l instanceof JobExecutionListenerSupport) {
+				b = true;
+			}
+		}
+		assertTrue(a);
+		assertTrue(b);
+
+		assertTrue(beans.containsKey("job2"));
+		Job job2 = (Job) ctx.getBean("job2");
+		List<?> job2Listeners = getListeners(job2);
+		assertEquals(1, job2Listeners.size());
+		boolean c = false;
+		for (Object l : job2Listeners) {
+			if (l instanceof JobExecutionListenerSupport) {
+				c = true;
+			}
+		}
+		assertTrue(c);
+	}
+
+	@SuppressWarnings("unchecked")
+	private List<?> getListeners(Job job) throws Exception {
+		assertTrue(job instanceof AbstractJob);
+		Field listenerField = AbstractJob.class.getDeclaredField("listener");
+		listenerField.setAccessible(true);
+		Object compositeListener = listenerField.get(job);
+
+		Field compositeField = CompositeExecutionJobListener.class.getDeclaredField("listeners");
+		compositeField.setAccessible(true);
+		Object composite = compositeField.get(compositeListener);
+
+		Class cls = Class.forName("org.springframework.batch.core.listener.OrderedComposite");
+		Field listField = cls.getDeclaredField("list");
+		listField.setAccessible(true);
+		List<JobExecutionListener> list = (List<JobExecutionListener>) listField.get(composite);
+
+		List<Object> listeners = new ArrayList<Object>();
+		for (Object listener : list) {
+			while (listener instanceof Advised) {
+				listener = ((Advised) listener).getTargetSource().getTarget();
+			}
+			listeners.add(listener);
+		}
+		return listeners;
+	}
+}