Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step

Browse Source 
http://jira.springframework.org/browse/BATCH-378

Add listener multicaster to ItemOrientedStep
This commit is contained in:
dsyer
2008-02-28 19:25:15 +00:00
parent 04f641d321
commit 9167c7de4c
9 changed files with 271 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spring-batch-core/src/main/java/org/springframework/batch/core/interceptor/CompositeJobListener.java
View File

@@ -22,7 +22,6 @@ import java.util.List;
import org.springframework.batch.core.domain.JobExecution;
import org.springframework.batch.core.domain.JobListener;
import org.springframework.batch.core.domain.StepListener;
/**
* @author Dave Syer
@@ -41,17 +40,6 @@ public class CompositeJobListener implements JobListener {
this.listeners = Arrays.asList(listeners);
}
/**
* Public setter for the listeners. The result will be as if
* {@link #setListeners(StepListener[])} was called with an array of length
* one.
*
* @param listener
*/
public void setListener(JobListener listener) {
setListeners(new JobListener[] {listener});
}
/**
* Register additional listener.
*

11
spring-batch-core/src/main/java/org/springframework/batch/core/interceptor/CompositeStepListener.java
View File

@@ -41,17 +41,6 @@ public class CompositeStepListener implements StepListener {
this.listeners = Arrays.asList(listeners);
}
/**
* Public setter for the listeners. The result will be as if
* {@link #setListeners(StepListener[])} was called with an array of length
* one.
*
* @param listener
*/
public void setListener(StepListener listener) {
setListeners(new StepListener[] {listener});
}
/**
* Register additional listener.
*

4
spring-batch-core/src/test/java/org/springframework/batch/core/interceptor/CompositeJobListenerTests.java
View File

@@ -58,7 +58,7 @@ public class CompositeJobListenerTests extends TestCase {
* {@link org.springframework.batch.core.interceptor.CompositeJobListener#setListener(org.springframework.batch.core.domain.JobListener)}.
*/
public void testSetListener() {
listener.setListener(new JobListenerSupport() {
listener.register(new JobListenerSupport() {
public void afterJob() {
list.add("fail");
}
@@ -72,7 +72,7 @@ public class CompositeJobListenerTests extends TestCase {
* {@link org.springframework.batch.core.interceptor.CompositeJobListener#beforeJob(JobExecution)}.
*/
public void testOpen() {
listener.setListener(new JobListenerSupport() {
listener.register(new JobListenerSupport() {
public void beforeJob(JobExecution stepExecution) {
list.add("foo");
}

6
spring-batch-core/src/test/java/org/springframework/batch/core/interceptor/CompositeStepListenerTests.java
View File

@@ -60,7 +60,7 @@ public class CompositeStepListenerTests extends TestCase {
* {@link org.springframework.batch.core.interceptor.CompositeStepListener#setListener(org.springframework.batch.core.domain.StepListener)}.
*/
public void testSetListener() {
listener.setListener(new StepListenerSupport() {
listener.register(new StepListenerSupport() {
public ExitStatus afterStep() {
list.add("fail");
return ExitStatus.FAILED;
@@ -75,7 +75,7 @@ public class CompositeStepListenerTests extends TestCase {
* {@link org.springframework.batch.core.interceptor.CompositeStepListener#beforeStep(StepExecution)}.
*/
public void testOpen() {
listener.setListener(new StepListenerSupport() {
listener.register(new StepListenerSupport() {
public void beforeStep(StepExecution stepExecution) {
list.add("foo");
}
@@ -89,7 +89,7 @@ public class CompositeStepListenerTests extends TestCase {
* {@link org.springframework.batch.core.interceptor.CompositeStepListener#beforeStep(StepExecution)}.
*/
public void testOnError() {
listener.setListener(new StepListenerSupport() {
listener.register(new StepListenerSupport() {
public ExitStatus onErrorInStep(Throwable e) {
list.add("foo");
return null;