diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/job/AbstractJob.java b/spring-batch-core/src/main/java/org/springframework/batch/core/job/AbstractJob.java index 345f1d194..22fee94e1 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/job/AbstractJob.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/job/AbstractJob.java @@ -44,9 +44,9 @@ import org.springframework.batch.core.launch.support.ExitCodeMapper; import org.springframework.batch.core.listener.CompositeJobExecutionListener; import org.springframework.batch.core.observability.BatchJobContext; import org.springframework.batch.core.observability.BatchJobObservation; -import org.springframework.batch.core.observability.BatchJobKeyValuesProvider; +import org.springframework.batch.core.observability.BatchJobObservationConvention; import org.springframework.batch.core.observability.BatchMetrics; -import org.springframework.batch.core.observability.DefaultBatchJobKeyValuesProvider; +import org.springframework.batch.core.observability.DefaultBatchJobObservationConvention; import org.springframework.batch.core.repository.JobRepository; import org.springframework.batch.core.repository.JobRestartException; import org.springframework.batch.core.scope.context.JobSynchronizationManager; @@ -86,7 +86,7 @@ public abstract class AbstractJob implements Job, StepLocator, BeanNameAware, In private StepHandler stepHandler; - private BatchJobKeyValuesProvider keyValuesProvider = new DefaultBatchJobKeyValuesProvider(); + private BatchJobObservationConvention observationConvention = new DefaultBatchJobObservationConvention(); /** * Default constructor. @@ -288,8 +288,8 @@ public abstract class AbstractJob implements Job, StepLocator, BeanNameAware, In LongTaskTimer.Sample longTaskTimerSample = longTaskTimer.start(); Observation observation = BatchMetrics .createObservation(BatchJobObservation.BATCH_JOB_OBSERVATION.getName(), new BatchJobContext(execution)) - .contextualName(execution.getJobInstance().getJobName()).keyValuesProvider(this.keyValuesProvider) - .start(); + .contextualName(execution.getJobInstance().getJobName()) + .observationConvention(this.observationConvention).start(); try (Observation.Scope scope = observation.openScope()) { jobParametersValidator.validate(execution.getJobParameters()); @@ -433,8 +433,8 @@ public abstract class AbstractJob implements Job, StepLocator, BeanNameAware, In jobRepository.update(jobExecution); } - public void setKeyValuesProvider(BatchJobKeyValuesProvider keyValuesProvider) { - this.keyValuesProvider = keyValuesProvider; + public void setObservationConvention(BatchJobObservationConvention observationConvention) { + this.observationConvention = observationConvention; } @Override diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchJobKeyValuesProvider.java b/spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchJobObservationConvention.java similarity index 80% rename from spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchJobKeyValuesProvider.java rename to spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchJobObservationConvention.java index ba6af7505..b6e20047f 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchJobKeyValuesProvider.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchJobObservationConvention.java @@ -19,12 +19,13 @@ package org.springframework.batch.core.observability; import io.micrometer.observation.Observation; /** - * {@link Observation.KeyValuesProvider} for {@link BatchJobContext}. + * {@link Observation.ObservationConvention} for {@link BatchJobContext}. * * @author Marcin Grzejszczak + * @author Mahmoud Ben Hassine * @since 5.0 */ -public interface BatchJobKeyValuesProvider extends Observation.KeyValuesProvider { +public interface BatchJobObservationConvention extends Observation.ObservationConvention { @Override default boolean supportsContext(Observation.Context context) { diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchStepKeyValuesProvider.java b/spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchStepObservationConvention.java similarity index 83% rename from spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchStepKeyValuesProvider.java rename to spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchStepObservationConvention.java index 41e80453a..bb1f812fd 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchStepKeyValuesProvider.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchStepObservationConvention.java @@ -19,13 +19,13 @@ package org.springframework.batch.core.observability; import io.micrometer.observation.Observation; /** - * {@link Observation.KeyValuesProvider} for {@link BatchStepContext}. + * {@link Observation.ObservationConvention} for {@link BatchStepContext}. * * @author Marcin Grzejszczak * @author Mahmoud Ben Hassine * @since 5.0 */ -public interface BatchStepKeyValuesProvider extends Observation.KeyValuesProvider { +public interface BatchStepObservationConvention extends Observation.ObservationConvention { @Override default boolean supportsContext(Observation.Context context) { diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchJobKeyValuesProvider.java b/spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchJobObservationConvention.java similarity index 91% rename from spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchJobKeyValuesProvider.java rename to spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchJobObservationConvention.java index 9c6a53fe9..29e19e4b5 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchJobKeyValuesProvider.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchJobObservationConvention.java @@ -20,13 +20,13 @@ import io.micrometer.common.KeyValues; import org.springframework.batch.core.JobExecution; /** - * Default {@link BatchJobKeyValuesProvider} implementation. + * Default {@link BatchJobObservationConvention} implementation. * * @author Marcin Grzejszczak * @author Mahmoud Ben Hassine * @since 5.0 */ -public class DefaultBatchJobKeyValuesProvider implements BatchJobKeyValuesProvider { +public class DefaultBatchJobObservationConvention implements BatchJobObservationConvention { @Override public KeyValues getLowCardinalityKeyValues(BatchJobContext context) { diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchStepKeyValuesProvider.java b/spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchStepObservationConvention.java similarity index 90% rename from spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchStepKeyValuesProvider.java rename to spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchStepObservationConvention.java index d81173908..003bb990e 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchStepKeyValuesProvider.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/observability/DefaultBatchStepObservationConvention.java @@ -20,13 +20,13 @@ import io.micrometer.common.KeyValues; import org.springframework.batch.core.StepExecution; /** - * Default {@link BatchStepKeyValuesProvider} implementation. + * Default {@link BatchStepObservationConvention} implementation. * * @author Marcin Grzejszczak * @author Mahmoud Ben Hassine * @since 5.0 */ -public class DefaultBatchStepKeyValuesProvider implements BatchStepKeyValuesProvider { +public class DefaultBatchStepObservationConvention implements BatchStepObservationConvention { @Override public KeyValues getLowCardinalityKeyValues(BatchStepContext context) { diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/step/AbstractStep.java b/spring-batch-core/src/main/java/org/springframework/batch/core/step/AbstractStep.java index 53ed19d90..5b2e07c91 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/step/AbstractStep.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/step/AbstractStep.java @@ -38,8 +38,8 @@ import org.springframework.batch.core.listener.CompositeStepExecutionListener; import org.springframework.batch.core.observability.BatchMetrics; import org.springframework.batch.core.observability.BatchStepContext; import org.springframework.batch.core.observability.BatchStepObservation; -import org.springframework.batch.core.observability.BatchStepKeyValuesProvider; -import org.springframework.batch.core.observability.DefaultBatchStepKeyValuesProvider; +import org.springframework.batch.core.observability.BatchStepObservationConvention; +import org.springframework.batch.core.observability.DefaultBatchStepObservationConvention; import org.springframework.batch.core.repository.JobRepository; import org.springframework.batch.core.scope.context.StepSynchronizationManager; import org.springframework.batch.item.ExecutionContext; @@ -74,7 +74,7 @@ public abstract class AbstractStep implements Step, InitializingBean, BeanNameAw private JobRepository jobRepository; - private BatchStepKeyValuesProvider keyValuesProvider = new DefaultBatchStepKeyValuesProvider(); + private BatchStepObservationConvention observationConvention = new DefaultBatchStepObservationConvention(); /** * Default constructor. @@ -202,7 +202,7 @@ public abstract class AbstractStep implements Step, InitializingBean, BeanNameAw Observation observation = BatchMetrics .createObservation(BatchStepObservation.BATCH_STEP_OBSERVATION.getName(), new BatchStepContext(stepExecution)) - .contextualName(stepExecution.getStepName()).keyValuesProvider(this.keyValuesProvider).start(); + .contextualName(stepExecution.getStepName()).observationConvention(this.observationConvention).start(); getJobRepository().update(stepExecution); // Start with a default value that will be trumped by anything @@ -418,8 +418,8 @@ public abstract class AbstractStep implements Step, InitializingBean, BeanNameAw return exitStatus; } - public void setKeyValuesProvider(BatchStepKeyValuesProvider keyValuesProvider) { - this.keyValuesProvider = keyValuesProvider; + public void setObservationConvention(BatchStepObservationConvention observationConvention) { + this.observationConvention = observationConvention; } }