Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - issue BATCH-570: Job.getSteps() does not need to be exposed in the interface

Browse Source 
Added getStepNames() to StepLocator.
This commit is contained in:
dsyer
2009-03-03 19:12:14 +00:00
parent 6cfc1ccc72
commit 9a3e55e58e
9 changed files with 96 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
spring-batch-core/src/test/java/org/springframework/batch/core/job/AbstractJobTests.java
View File

@@ -15,8 +15,14 @@
*/
package org.springframework.batch.core.job;
import static org.junit.Assert.*;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import java.util.Collection;
import java.util.Collections;
import java.util.Date;
import org.junit.Test;
@@ -174,6 +180,11 @@ public class AbstractJobTests {
public Step getStep(String stepName) {
return null;
}
@Override
public Collection<String> getStepNames() {
return Collections.<String> emptySet();
}
}

8
spring-batch-core/src/test/java/org/springframework/batch/core/job/SimpleJobTests.java
View File

@@ -147,6 +147,14 @@ public class SimpleJobTests {
assertEquals(1, jobExecution.getStepExecutions().size());
}
/**
* Test method for {@link SimpleJob#setSteps(java.util.List)}.
*/
@Test
public void testGetSteps() {
assertEquals(2, job.getStepNames().size());
}
/**
* Test method for
* {@link SimpleJob#addStep(org.springframework.batch.core.Step)}.

14
spring-batch-core/src/test/java/org/springframework/batch/core/job/flow/FlowJobTests.java
View File

@@ -67,6 +67,20 @@ public class FlowJobTests {
jobExecution = jobRepository.createJobExecution("job", new JobParameters());
}
@Test
public void testGetSteps() throws Exception {
SimpleFlow flow = new SimpleFlow("job");
List<StateTransition> transitions = new ArrayList<StateTransition>();
transitions.add(StateTransition.createStateTransition(new StepState(new StubStep("step1")), "step2"));
transitions.add(StateTransition.createStateTransition(new StepState(new StubStep("step2")), "end0"));
transitions.add(StateTransition.createEndStateTransition(new EndState(FlowExecutionStatus.COMPLETED, "end0")));
flow.setStateTransitions(transitions);
flow.afterPropertiesSet();
job.setFlow(flow);
job.afterPropertiesSet();
assertEquals(2, job.getStepNames().size());
}
@Test
public void testTwoSteps() throws Exception {
SimpleFlow flow = new SimpleFlow("job");